fix: persist site config via setConfig after disableImport

[prithipalpatwal]

Site save tracks updates through setters; mutating getConfig() alone did not reliably persist import changes. Calling setConfig(Config.toDynamoItem(siteConfig)) before save.

Tests mock Config.toDynamoItem and assert setConfig on success paths, and that setConfig is skipped when the site is not found or lookup fails.

Made-with: Cursor

Please ensure your pull request adheres to the following guidelines:

• make sure to link the related issues in this description
• when merging / squashing, make sure the fixed issue references are visible in the commits, for easy compilation of release notes

Related Issues

Thanks for contributing!

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

[tkotthakota-adobe]

Hi @prithipalpatwal

 Assessment                                                              
   
  The fix is correct. This is a real bug — Config is a wrapper object, not
   a plain reference to site.state.config. Mutating it doesn't
  automatically mark the site as dirty. Config.toDynamoItem() serializes  
  it back to the raw format that setConfig expects.         

  One concern — import path:                                              
   
  import { Config } from                                                  
  '@adobe/spacecat-shared-data-access/src/models/site/config.js';         
                                                                          
  This imports directly from an internal src/ path of the published       
  package, not from its public entry point. This is fragile — internal
  paths can change without a semver bump. It works now but could break on 
  a lib update.                                             

  Ideally Config and toDynamoItem should be exported from the package's   
  public index.js. Worth checking if there's an alternative export, or
  raising it with the shared-data-access team to expose toDynamoItem      
  publicly.                                                 

  Tests are thorough — every code path (success, errors, edge cases)      
  asserts both toDynamoItemStub and setConfig were called correctly. The
  negative cases (errors before setConfig is reached) correctly assert    
  setConfig was not called.                                 

  Overall: good to merge, with the internal import path being a minor     
  concern to track.
                    

[tkotthakota-adobe]

This imports directly from an internal src/ path of the published
package, not from its public entry point. This is fragile — internal
paths can change without a semver bump. It works now but could break on
a lib update.

Ideally Config and toDynamoItem should be exported from the package's
public index.js. Worth checking if there's an alternative export, or
raising it with the shared-data-access team to expose toDynamoItem
publicly.

[prithipalpatwal]

Updated the PR, will merge it tomorrow. Thanks!

[github-actions]

This PR will trigger a patch release when merged.

[solaris007]

🎉 This PR is included in version 1.12.19 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀