fix: enforce curly braces and remove eslint-env comments#253
Open
solaris007 wants to merge 1 commit intomainfrom
Open
fix: enforce curly braces and remove eslint-env comments#253solaris007 wants to merge 1 commit intomainfrom
solaris007 wants to merge 1 commit intomainfrom
Conversation
Remove curly: off override from eslint config now that code complies with the curly rule from eslint-config-helix 3.0.24. Remove redundant eslint-env comments (globals configured by helix test preset).
|
This PR will trigger a patch release when merged. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
curly: offoverride from eslint config/* eslint-env */commentsCompanion to adobe/spacecat-shared#1521.
Test plan
npm run lintpassesnpm testpasses