Skip to content

Commit c9cb58d

Browse files
committed
chore: minor clean up
1 parent 357e0c9 commit c9cb58d

3 files changed

Lines changed: 4 additions & 9 deletions

File tree

2nd-gen/packages/swc/components/progress-circle/ProgressCircle.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ import styles from './progress-circle.css';
2727
/**
2828
* Progress circles show the progression of a system operation such as downloading, uploading, processing, etc. in a visual way.
2929
*
30-
* They can represent determinate (with a specific progress value) or indeterminate (loading) progress.
30+
* They can represent determinate (with a specific progress value) or indeterminate (loading) progress. If no `progress` value is given, the progress circle is indeterminate.
3131
*
3232
* @element swc-progress-circle
3333
* @status preview

2nd-gen/packages/swc/components/progress-circle/stories/progress-circle.stories.ts

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -29,12 +29,6 @@ import '@adobe/spectrum-wc/progress-circle';
2929

3030
const { args, argTypes, template } = getStorybookHelpers('swc-progress-circle');
3131

32-
// @todo Blurring the range control seems to cause a catastrophic Storybook render failure, so using number input for now. React spectrum has the range control working, check their implementation for a solution.
33-
// argTypes.progress = {
34-
// ...argTypes.progress,
35-
// control: { type: 'number', min: 0, max: 100, step: 1 },
36-
// };
37-
3832
argTypes.size = {
3933
...argTypes.size,
4034
control: { type: 'select' },
@@ -291,12 +285,13 @@ export const ProgressValues: Story = {
291285
* - Use specific, meaningful labels (e.g., "Uploading profile photo" instead of "Loading")
292286
* - Use determinate progress (`progress="50"`) when possible to give users a clear sense of completion
293287
* - For determinate progress, ensure the `progress` value accurately reflects the actual progress
294-
* - Use indeterminate progress only when duration is truly unknown
288+
* - Use indeterminate progress only when duration is truly unknown or when the wait is less than 3 seconds.
295289
* - Consider using `size="l"` for primary loading states to improve visibility
296290
* - Ensure sufficient color contrast between the progress circle and its background
297291
* - Use `static-color="white"` on dark backgrounds or `static-color="black"` on light backgrounds
298292
* - Test with screen readers to verify progress announcements are clear and timely
299293
* - Avoid updating progress values more frequently than every 1-2 seconds to prevent announcement overload
294+
* - Do not force live region announcements for progress durations that are 3 seconds or less. Instead, consider status messages when progress is complete or there is an error
300295
*/
301296
export const Accessibility: Story = {
302297
tags: ['a11y'],

2nd-gen/packages/swc/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@
126126
"component",
127127
"css"
128128
],
129-
"customElements": "custom-elements.json",
129+
"customElements": ".storybook/custom-elements.json",
130130
"publishConfig": {
131131
"access": "public"
132132
}

0 commit comments

Comments
 (0)