Skip to content

docs: update pr review guidance#6154

Merged
caseyisonit merged 3 commits intomainfrom
rise-erpelding/pr-review-guidelines
Apr 13, 2026
Merged

docs: update pr review guidance#6154
caseyisonit merged 3 commits intomainfrom
rise-erpelding/pr-review-guidelines

Conversation

@rise-erpelding
Copy link
Copy Markdown
Collaborator

Description

Expands Participating in PR reviews with practices from a team discussion on review depth (edge cases, Storybook/Chromatic/playgrounds), communication, scope and timing, and collaboration.

Motivation and context

Captures notes from our discussion (summarized in the 1st commit), then integrates them into our existing docs.

Author's checklist

  • I have read the CONTRIBUTING and PULL_REQUESTS documents.
  • [] I have reviewed at the Accessibility Practices for this feature, see: Aria Practices
  • I have added automated tests to cover my changes.
  • I have included a well-written changeset if my change needs to be published.
  • I have included updated documentation if my change required it.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 8, 2026

⚠️ No Changeset found

Latest commit: dfa7ca0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@rise-erpelding rise-erpelding added the Component:Documentation Issues or PRs involving changes to docs or docs website. Component prefix is for Jira integration. label Apr 8, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 8, 2026

📚 Branch Preview Links

🔍 First Generation Visual Regression Test Results

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

Deployed to Azure Blob Storage: pr-6154

If the changes are expected, update the current_golden_images_cache hash in the circleci config to accept the new images. Instructions are included in that file.
If the changes are unexpected, you can investigate the cause of the differences and update the code accordingly.

@rise-erpelding rise-erpelding marked this pull request as ready for review April 8, 2026 18:38
@rise-erpelding rise-erpelding requested a review from a team as a code owner April 8, 2026 18:38
@rise-erpelding rise-erpelding added the Status:Ready for review PR ready for review or re-review. label Apr 8, 2026
@caseyisonit caseyisonit added the Status:Ready for merge PR has 2 approvals, all tests pass, and is ready to merge label Apr 10, 2026
@caseyisonit caseyisonit enabled auto-merge (squash) April 13, 2026 15:59
@caseyisonit caseyisonit merged commit 34fbcad into main Apr 13, 2026
28 of 35 checks passed
@caseyisonit caseyisonit deleted the rise-erpelding/pr-review-guidelines branch April 13, 2026 16:45
cdransf pushed a commit that referenced this pull request Apr 14, 2026
* docs: first pass of pr review notes summary

* docs: integrate pr notes into existing pr reviews docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component:Documentation Issues or PRs involving changes to docs or docs website. Component prefix is for Jira integration. Status:Ready for merge PR has 2 approvals, all tests pass, and is ready to merge Status:Ready for review PR ready for review or re-review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants