Skip to content

feat(ci): add StackBlitz collection link to PR preview comment#6158

Closed
Rajdeepc wants to merge 2 commits intomainfrom
rajdeepchandra/feat-pr-comment-stackblitz-links
Closed

feat(ci): add StackBlitz collection link to PR preview comment#6158
Rajdeepc wants to merge 2 commits intomainfrom
rajdeepchandra/feat-pr-comment-stackblitz-links

Conversation

@Rajdeepc
Copy link
Copy Markdown
Contributor

@Rajdeepc Rajdeepc commented Apr 9, 2026

Link to the SWC-Team Spectrum Web Components StackBlitz collection in the same automated comment as Azure Storybook previews, with a note that demos use published packages and are not branch-specific.

Made-with: Cursor

Description

Motivation and context

Related issue(s)

  • fixes [Issue Number]

Screenshots (if appropriate)


Author's checklist

  • I have read the CONTRIBUTING and PULL_REQUESTS documents.
  • I have reviewed at the Accessibility Practices for this feature, see: Aria Practices
  • I have added automated tests to cover my changes.
  • I have included a well-written changeset if my change needs to be published.
  • I have included updated documentation if my change required it.

Reviewer's checklist

  • Includes a Github Issue with appropriate flag or Jira ticket number without a link
  • Includes thoughtfully written changeset if changes suggested include patch, minor, or major features
  • Automated tests cover all use cases and follow best practices for writing
  • Validated on all supported browsers
  • All VRTs are approved before the author can update Golden Hash

Manual review test cases

  • Descriptive Test Statement

    1. Go here
    2. Do this action
    3. Expect this result
  • Descriptive Test Statement

    1. Go here
    2. Do this action
    3. Expect this result

Device review

  • Did it pass in Desktop?
  • Did it pass in (emulated) Mobile?
  • Did it pass in (emulated) iPad?

Accessibility testing checklist

Required: Complete each applicable item and document your testing steps (replace the placeholders with your component-specific instructions).

  • Keyboard (required — document steps below) — What to test for: Focus order is logical; Tab reaches the component and all interactive descendants; Enter/Space activate where appropriate; arrow keys work for tabs, menus, sliders, etc.; no focus traps; Escape dismisses when applicable; focus indicator is visible.

    1. Go here
    2. Do this action
    3. Expect this result
  • Screen reader (required — document steps below) — What to test for: Role and name are announced correctly; state changes (e.g. expanded, selected) are announced; labels and relationships are clear; no unnecessary or duplicate announcements.

    1. Go here
    2. Do this action
    3. Expect this result

Link to the SWC-Team Spectrum Web Components StackBlitz collection in the
same automated comment as Azure Storybook previews, with a note that demos
use published packages and are not branch-specific.

Made-with: Cursor
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 9, 2026

⚠️ No Changeset found

Latest commit: 2ed91b3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Rajdeepc Rajdeepc added the do-not-merge NO MERGE-Y! label Apr 9, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 9, 2026

📚 Branch Preview Links

🧪 StackBlitz

Branch / commit

Curated collection (SWC-Team workspace; published package demos)

Story-linked templates (from 2nd-gen parameters.stackblitz.url; standalone StackBlitz projects use the published npm package—use Storybook previews above for this branch’s build)

  • badge2nd-gen/packages/swc/components/badge/stories/badge.stories.ts
  • divider2nd-gen/packages/swc/components/divider/stories/divider.stories.ts
  • progress-circle2nd-gen/packages/swc/components/progress-circle/stories/progress-circle.stories.ts
  • status-light2nd-gen/packages/swc/components/status-light/stories/status-light.stories.ts

🔍 First Generation Visual Regression Test Results

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

Deployed to Azure Blob Storage: pr-6158

If the changes are expected, update the current_golden_images_cache hash in the circleci config to accept the new images. Instructions are included in that file.
If the changes are unexpected, you can investigate the cause of the differences and update the code accordingly.

- Scan 2nd-gen Storybook CSF files for parameters.stackblitz.url and list
  them in the automated PR comment (deduped, sorted by component).
- Add StackBlitz fork link to the PR head commit using head.repo.full_name
  so fork PRs resolve correctly.
- Clarify that curated and story template links use published npm packages;
  Storybook previews remain the branch-accurate UI review.

Made-with: Cursor
Comment on lines +21 to +22
/**
* Collect `.stories.ts` files under a directory (recursive).
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <jsdoc/tag-lines> reported by reviewdog 🐶
Expected 1 lines after block description

Suggested change
/**
* Collect `.stories.ts` files under a directory (recursive).
/**
* Collect `.stories.ts` files under a directory (recursive).
*

Comment on lines +51 to +52
/**
* Parse `parameters.stackblitz.url` from a Storybook CSF file (best-effort regex).
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <jsdoc/tag-lines> reported by reviewdog 🐶
Expected 1 lines after block description

Suggested change
/**
* Parse `parameters.stackblitz.url` from a Storybook CSF file (best-effort regex).
/**
* Parse `parameters.stackblitz.url` from a Storybook CSF file (best-effort regex).
*

Comment on lines +63 to +64
/**
* Derive a short component label from `.../components/<name>/stories/...`.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <jsdoc/tag-lines> reported by reviewdog 🐶
Expected 1 lines after block description

Suggested change
/**
* Derive a short component label from `.../components/<name>/stories/...`.
/**
* Derive a short component label from `.../components/<name>/stories/...`.
*

@Rajdeepc Rajdeepc closed this Apr 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge NO MERGE-Y!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant