chore(progress-bar): storybook, tests and update to migration skill#6456
Conversation
|
📚 Branch Preview Links🔍 First Generation Visual Regression Test ResultsWhen a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:
Deployed to Azure Blob Storage: If the changes are expected, update the |
| consoleWarnStub.restore(); | ||
| }); | ||
|
|
||
| it('warns in Dev Mode when accessible attributes are not leveraged', async () => { |
There was a problem hiding this comment.
This is a duplicte test in the file.
| const spyCall = consoleWarnStub.getCall(0); | ||
| const spyCall = consoleWarnStub | ||
| .getCalls() | ||
| .find((call: { args: unknown[] }) => |
There was a problem hiding this comment.
Updated the test to be more specific in finding the call. Previously it was just getting the first response, but with the addition of deprecated dev warnings, this broke.
7f3554a
into
miwhabonini/feat-progress-bar-swc-1769
Description
Completes the documentation, Storybook, and test surface for the 2nd-gen progress bar migration, and adds the 1st-gen deprecation warnings for the properties that change in 2nd-gen. Also updates the
migration-apiskill so future migrations add runtime deprecation warnings alongside@deprecatedJSDoc.Motivation and context
The base migration branch landed the 2nd-gen component; this change finishes the consumer-facing surface (docs, stories, tests) and ensures 1st-gen consumers get runtime deprecation guidance for the APIs that changed, not just IDE-only JSDoc.
Related issue(s)
Screenshots (if appropriate)
Author's checklist
patchchangeset for@spectrum-web-components/progress-barif this targets a release branch.)Reviewer's checklist
patch,minor, ormajorfeaturesManual review test cases
1st-gen progress-bar unit tests pass, including deprecation warnings
cd 1st-genyarn build && yarn test:start --group progress-barlabel/side-label/progressdeprecation warnings fire only in dev mode with the expecteddatashape2nd-gen progress-bar docs page renders
2nd-gen/packages/swc2nd-gen progress-bar tests pass on all engines
2nd-gen/packages/swcVITEST_BROWSER_INSTANCES=chromium,firefox,webkit yarn vitest --run --project storybook progress-barDescriptionPresentTeston WebKitDevice review
Accessibility testing checklist
Keyboard (required — document steps below)
Screen reader (required — document steps below)
progressbarrole announced; accessible name from thelabelslot oraccessible-label;aria-valuenow/aria-valuetextread for determinate bars and suppressed for indeterminate;descriptionslot announced viaaria-describedbywhen present and not announced once removed