Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 7 additions & 11 deletions .ai/skills/accessibility-migration-analysis/SKILL.md
Original file line number Diff line number Diff line change
Expand Up @@ -246,20 +246,16 @@ In the **body**, point to the **Browse mode (document/scan mode)** section. Add

## Pull request

When the analysis doc is complete and ready for review, generate a GitHub PR description using the template below.
When the analysis doc is complete and ready for review, generate a GitHub PR description using the template below. Always output the filled-in description inside a single fenced `markdown` code block so the user can copy it in one action.

### Variable substitution rules

| Placeholder | Value | Example |
| ------------------------------------------ | --------------------------------------------------------------------- | -------------------------------- |
| `{{component-name}}` | Package name, kebab-case | `dropzone`, `picker-button` |
| `{{branch-name}}` | GitHub branch, format `<username>/swc-<jira-number>-<component>-a11y` | `nikkimk/swc-2146-dropzone-a11y` |
| `{{component-a11y-migration-JIRA-ticket}}` | Jira ID for this component's a11y migration analysis ticket | `SWC-2146` |
| `{{component-readable-name}}` | Human-readable name, first letter capitalized | `Dropzone`, `Color handle` |

The description's first bullet ends "for the 2nd-gen color handle" in the source template — replace "color handle" with `{{component-readable-name}}` when filling in.

The Manual review test cases section contains a fixed reference to the color handle PR (`nikkimk/swc-2138-color-handle-a11y`). Keep that reference as-is; it is an anchor PR that all reviewers in this migration wave are expected to read.
| Placeholder | Value | Example |
| ------------------------------------------ | --------------------------------------------------------------------- | ----------------------- |
| `{{component-name}}` | Package name, kebab-case | `icon`, `picker-button` |
| `{{branch-name}}` | GitHub branch, format `<username>/swc-<jira-number>-<component>-a11y` | `nikkimk/icon-a11y` |
| `{{component-a11y-migration-JIRA-ticket}}` | Jira ID for this component's a11y migration analysis ticket | `SWC-2146` |
| `{{component-readable-name}}` | Human-readable name, first letter capitalized | `Icon`, `Color handle` |

### PR settings

Expand Down
7 changes: 3 additions & 4 deletions 2nd-gen/packages/swc/.storybook/preview.ts
Original file line number Diff line number Diff line change
Expand Up @@ -423,6 +423,8 @@ const preview = {
],
'Help text',
['Rendering and styling migration analysis'],
'Icon',
['Accessibility migration analysis'],
'Illustrated message',
[
'Accessibility migration analysis',
Expand Down Expand Up @@ -524,10 +526,7 @@ const preview = {
'Rendering and styling migration analysis',
],
'Toast',
[
'Accessibility migration analysis',
'Rendering and styling migration analysis',
],
['Accessibility migration analysis'],
'Tooltip',
[
'Accessibility migration analysis',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,8 @@
- [Grid migration roadmap](grid/rendering-and-styling-migration-analysis.md)
- Help Text
- [Help text migration roadmap](help-text/rendering-and-styling-migration-analysis.md)
- Icon
- [Icon accessibility migration analysis](icon/accessibility-migration-analysis.md)
- Illustrated Message
- [Illustrated message accessibility migration analysis](illustrated-message/accessibility-migration-analysis.md)
- [`sp-illustrated-message` Migration Plan](illustrated-message/migration-plan.md)
Expand Down
Loading
Loading