Limit external Tomcat & Derby tests to startup verification#7252
Limit external Tomcat & Derby tests to startup verification#7252samyoon20 wants to merge 1 commit into
Conversation
92d9d1e to
cd554fe
Compare
|
@smlambert Hi! When you have time, could I get a review of the direction I'm heading with the test approach I have for tomcat and derby tests? I have two tests that I used as our standard example that if idea is good, we could apply directly to the other related external tests that are listed above. I used disables so the full suite is preserved but not auto-run in CI. To re-enable the full suite, the only change needed is removing the disables block, test.sh already has the full suite command gated behind $1=full, and the playlist already passes --testtarget full. https://ci.adoptium.net/job/Grinder/17568/ tomcat_startup_test: derby_startup_test: |
4f7fb22 to
d86d990
Compare
…ium#7243) Default run (no arg) performs a lightweight startup probe. Full upstream test suite is preserved behind --testtarget full and disabled via adoptium#7243. - tomcat: ant build + catalina.sh start + curl :8080 - derby: ant build + java -jar derbyrun.jar sysinfo Re-enable full suite: remove <disables> block from playlist entry.
0aa7bd6 to
37fde13
Compare
Summary
Implements startup-only verification for two external tests (Tomcat and Derby). This addresses the roadmap item listed in external/README.md — "Startup-only testing (application startup, but not full runs of app functional testing)" — and tracks issue #7243.
Changes
'external/tomcat/' - server-style startup verification
playlist.xml: Keeps tomcat_test at extended level, disabled. Remove disables block to reenable
'external/derby/' — tool-style startup verification
Reason
The full upstream test suites test the applications themselves, not the JDK. A failure in a Tomcat or Derby unit test is almost certainly an application-level issue, not a JDK defect. What Adoptium needs to verify is: can this JDK launch this application without crashing? A startup check that's much faster than running entire test suite
This is the first "attempt/implementation" of the startup-only pattern listed in 'external/README.md' as planned improvement
Phase 2 -> extending to the other tests that follow similar patterns
The tool-style pattern extends directly to:
The server-style pattern extends directly to:
Parts assisted by IBM Bob