Fix/fix certificate provisioning failures caused by acme account serialization issue and localstack auth changes#136
Conversation
Awambeng
left a comment
There was a problem hiding this comment.
Thanks for these improvements @Hermann-Core.
Since the ACME serialization issue was resolved mainly through the library upgrades, it might be worth adding a small 'save and load' regression test for the ACME account.
This would ensure that if a future library update breaks serialization again, we catch it during testing rather than hitting rate limits in production
IngridPuppet
left a comment
There was a problem hiding this comment.
I tried running docker compose up --build and left some comments. Please could you check?
We are running the full test suite using |
|
Hello @Awambeng @IngridPuppet thank you for the reviews. The issues have been fixed, could you have another look?
|
Awambeng
left a comment
There was a problem hiding this comment.
Hi @Hermann-Core, thank you for adding the new test.
The current integration tests validate the full provisioning and renewal flows, but they do not explicitly verify ACME account serialization/deserialization.
Since the serialization issue was mainly resolved through dependency upgrades, I think it could still be valuable to add a dedicated regression test for the ACME account persistence flow to catch future serialization issues early. WDYT?
Instead of creating isolated tests for each individual component of the ACME flow, I decided to validate the entire certificate provisioning flow end-to-end. This allows us to test not only the account serialization and persistence logic which are themselves part of the provisioning process, but also the interaction between all components involved in the flow. As a result, if an issue occurs at any stage of the provisioning pipeline, it can be detected through the integration test as well. |
Okay, It's fine then. Thank you! |
…rovisioning-failures-caused-by-acme-account-serialization-issue-and-localstack-auth-changes
|
Hello @IngridPuppet @Awambeng I have fixed the merge conflicts, could you have another look or approve again so we can merge? |



This ticket tracks dependency and local infrastructure updates required to fix:
instant-acmecrate.LocalStackDocker images now requiring an authentication token by default.The main goal of this ticket is to stabilize certificate issuance/renewal flows and restore reliable local testing environments through dependency upgrades and explicit service version pinning.
Infrastructure / Docker updates
LocalStackDocker image version to4.14latesttags in Docker Compose and CI environmentsTasks
Acceptance Criteria