Merged
Conversation
…4026) * NavigationPanel and CustomContent elements added Navigation buttons still need to take "disabled" tabs into account * NavigationPanel now takes disabled tabs into account * Adding samples to demo app * Add UI test for NavigationPanel visibility (and supporting AP) * Add AP to control placement of navigation panel Update UI tests accordingly * Add TabAssist.NavigationPanelBehavior to control button functionality * Add UI tests for TabAssist.NavigationPanelBehavior * Attempt at fixing timing issue in UI test * Add sample of new APs in demo app * Fix issue where navigating right could actually exceed the extent width * Fix bug mentioned by keboo in review BringIntoView direction is now dependent on the nav panel behavior. For scroll behavior, the current scroll position compared to the "next" tab determines the direction, whereas for select behavior, it is simply the index of the "next" tab that needs to be considered. * Add UI test from Corvinz review * Set explicit default values for enum based APs * Minor bug fix. When no next index, return "default value" * Ensure behavior does not break Visual Studio XAML Designer
* Initial plan * Add materialDesignInternal XML namespace and update README documentation Agent-Logs-Url: https://github.com/MaterialDesignInXAML/MaterialDesignInXamlToolkit/sessions/7b42c504-036c-4afa-bada-baba0a8efd08 Co-authored-by: nicolaihenriksen <19572699+nicolaihenriksen@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: nicolaihenriksen <19572699+nicolaihenriksen@users.noreply.github.com>
* adding unit tests for custom swatch colors * Update tests/MaterialColorUtilities.Tests/CustomSemanticSwatchTests.cs Co-authored-by: Kevin B <Keboo@users.noreply.github.com> * Fix redundant loop in CustomSemanticSwatches test The test method was using a nested loop that shadowed the `isDark` parameter, causing redundant executions. This change removes the inner loop and uses the parameter directly. --------- Co-authored-by: Johann Dirry <johann.dirry@microsea.at> Co-authored-by: Kevin B <Keboo@users.noreply.github.com> Co-authored-by: Kevin Bost <kitokeboo@gmail.com>
* test(dialoghost): add failing test for the focus not being trapped inside of the dialogs popup * fix(dialoghost): trap focus inside of the dialogs popup * test(dialoghost): stabilize focus tests by using Wait.For Replace fixed Task.Delay calls with polling assertions to improve test reliability during focus transitions. Fixes #4027 --------- Co-authored-by: corvinsz <corvinszimion@gmail.com> Co-authored-by: Kevin Bost <kitokeboo@gmail.com>
) Bumps [fastify/github-action-merge-dependabot](https://github.com/fastify/github-action-merge-dependabot) from 3.11.2 to 3.12.0. - [Release notes](https://github.com/fastify/github-action-merge-dependabot/releases) - [Commits](fastify/github-action-merge-dependabot@v3.11.2...v3.12.0) --- updated-dependencies: - dependency-name: fastify/github-action-merge-dependabot dependency-version: 3.12.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Implementing DynamicColorTool which is showcasing dynamic color palette generation * Include Demo3 app in release artifacts Add MaterialDesign3.Demo.Wpf (Demo3App) alongside the existing MainDemo.Wpf (DemoApp) in the build and release workflows: - Upload Demo3App build output as a separate artifact in build_artifacts.yml - Download, zip, and attach Demo3App.zip to the GitHub release in release.yml Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Fix flaky TabControl navigation panel UI tests Replace brittle Task.Delay calls with Wait.For retry-based waits in three scrolling tab navigation panel tests that were failing intermittently on CI: - ScrollingTabs_WithNavigationPanelAndSelectBehavior_ShouldChangeSelectedTabWhenClicked - ScrollingTabs_WithNavigationPanelAndScrollBehavior_ShouldScrollWhenClicked - ScrollingTabs_NavigationPanel_ScrollsAndBringsSelectedTabIntoView Changes: - Wait for IsOverflowing to be true before clicking navigation buttons, ensuring layout is complete instead of using fixed Task.Delay(100-300ms) - Use Wait.For with Retry(10, 5s) after clicks to poll for the expected state change (selected index or scroll offset) instead of fixed delays - Track scroll offset before/after navigation clicks for precise assertions Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Fix flaky TabControl navigation panel UI tests Improve test reliability by ensuring navigation buttons are enabled before interaction and wrapping click actions within Wait.For retry blocks to better capture state changes. - Wait for right navigation button to be enabled before clicking - Include LeftClick() within the retry logic to handle intermittent input failures - Relax selected index assertion to be more resilient during scrolling --------- Co-authored-by: Johann Dirry <johann.dirry@microsea.at> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…4028) * Fix ToolBar overflow button background not inheriting from ToolBar Change the overflow button styles to bind their Background to the ancestor ToolBar's Background instead of hardcoding the theme resource. This ensures the overflow button matches when a custom Background is set on the ToolBar. Changes: - Both vertical and horizontal overflow button styles now use a RelativeSource binding to the parent ToolBar's Background - Overflow popup border uses TemplateBinding to inherit Background - Removed redundant Background reset in the vertical orientation trigger Fixes #3694 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Add demo toolbar with custom background to showcase overflow button fix Adds a second toolbar example in both MainDemo and MaterialDesign3.Demo that uses a custom background with overflow items forced via OverflowMode=Always, demonstrating that the overflow button now inherits the toolbar's background color. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Update demo toolbar background to standard Primary brush Updates the custom background ToolBar in the demo app to use the standard Primary brush instead of the Dark variant. This continues to demonstrate that the overflow button correctly inherits the ToolBar's background color while using a more conventional theme resource. --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…te generation (#4034) * Implementing DynamicColorTool which is showcasing dynamic color palette generation * DynamicColorTool: improve layout and update demo defaults - Removes the ScrollViewer from the main layout of DynamicColorTool. - Sets the navigation drawer to be closed by default in the demo application. - Modernizes collection initialization in DynamicColorToolViewModel using collection expressions. - Adjusts the Z-order and hit testing for the copy color button in the color tiles to improve interaction. --------- Co-authored-by: Johann Dirry <johann.dirry@microsea.at> Co-authored-by: Kevin Bost <kitokeboo@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update