fixup! fixup! tools: add GHA benchmark runner

Author: aduh95

.github/workflows/benchmark.yml

@@ -1,6 +1,7 @@
 name: Benchmark
 
 on:
+  push:
   workflow_dispatch:
     inputs:
       repo:
@@ -30,132 +31,8 @@ permissions:
   contents: read
 
 jobs:
-  build:
-    strategy:
-      fail-fast: true
-      matrix:
-        include:
-          - runner: ubuntu-24.04
-            system: x86_64-linux
-          - runner: ubuntu-24.04-arm
-            system: aarch64-linux
-          - runner: macos-15-intel
-            system: x86_64-darwin
-          - runner: macos-latest
-            system: aarch64-darwin
-    name: '${{ matrix.system }}: with shared libraries'
-    runs-on: ${{ matrix.runner }}
-    steps:
-      - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd  # v6.0.2
-        with:
-          repository: ${{ inputs.repo || github.repository }}
-          ref: refs/pull/${{ inputs.pr_id }}/merge
-          persist-credentials: false
-          fetch-depth: 2
-
-      - name: Validate PR head and roll back to base commit
-        run: |
-          [ "$(git rev-parse HEAD^2)" = "$EXPECTED_SHA" ]
-          git reset HEAD^ --hard
-        env:
-          EXPECTED_SHA: ${{ inputs.commit }}
-
-      - uses: cachix/install-nix-action@96951a368ba55167b55f1c916f7d416bac6505fe  # v31.10.3
-        with:
-          extra_nix_config: sandbox = true
-
-      - uses: cachix/cachix-action@1eb2ef646ac0255473d23a5907ad7b04ce94065c  # v17
-        with:
-          # We do not pass any `authToken` to avoid polluting the cache with potentially untrusted code.
-          name: nodejs
-
-      - name: Configure sccache
-        uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd  # v8.0.0
-        with:
-          script: |
-            core.exportVariable('SCCACHE_GHA_VERSION', 'on');
-            core.exportVariable('ACTIONS_CACHE_SERVICE_V2', 'on');
-            core.exportVariable('ACTIONS_RESULTS_URL', process.env.ACTIONS_RESULTS_URL || '');
-            core.exportVariable('ACTIONS_RUNTIME_TOKEN', process.env.ACTIONS_RUNTIME_TOKEN || '');
-
-      - name: Build Node.js on the base commit
-        run: |
-          nix-shell \
-            -I nixpkgs=./tools/nix/pkgs.nix \
-            --pure --keep TAR_DIR --keep FLAKY_TESTS \
-            --keep SCCACHE_GHA_ENABLED --keep ACTIONS_CACHE_SERVICE_V2 --keep ACTIONS_RESULTS_URL --keep ACTIONS_RUNTIME_TOKEN \
-            --arg useSeparateDerivationForV8 true \
-            --arg loadJSBuiltinsDynamically false \
-            --arg ccache "${NIX_SCCACHE:-null}" \
-            --arg devTools '[]' \
-            --arg benchmarkTools '[]' \
-            --run '
-                make build-ci -j4 V=1
-            '
-          mv out/Release/node base_node
-
-      - name: Checkout the merge commit
-        run: git reset FETCH_HEAD --hard
-
-      - name: Re-build Node.js on the merge commit
-        # ccache is disabled here to avoid polluting the cache. Local build outputs should make this build relatively quick anyway.
-        run: |
-          nix-shell \
-            -I nixpkgs=./tools/nix/pkgs.nix \
-            --pure \
-            --arg useSeparateDerivationForV8 true \
-            --arg loadJSBuiltinsDynamically false \
-            --arg ccache 'null' \
-            --arg devTools '[]' \
-            --arg benchmarkTools '[]' \
-            --run '
-                make -j4 V=1
-            '
-
-      - name: Run benchmark
-        run: |
-          nix-shell \
-            -I nixpkgs=./tools/nix/pkgs.nix \
-            --pure --keep FILTER --keep LC_ALL --keep LANG \
-            --arg loadJSBuiltinsDynamically false \
-            --arg ccache 'null' \
-            --arg icu 'null' \
-            --arg sharedLibDeps '{}' \
-            --arg devTools '[]' \
-            --run '
-                set -o pipefail
-                ./base_node benchmark/compare.js \
-                  --filter "$FILTER" \
-                  --runs ${{ inputs.runs }} \
-                  --old ./base_node --new ./node \
-                  -- ${{ inputs.category }} \
-                | tee /dev/stderr \
-                > ${{ matrix.system }}.csv
-                echo "> [!WARNING] "
-                echo "> Do not take GHA benchmark results as face value, always confirm them"
-                echo "> using a dedicated machine, e.g. Jenkins CI."
-                echo
-                echo "Benchmark results:"
-                echo
-                echo '"'"'```'"'"'
-                Rscript benchmark/compare.R < ${{ matrix.system }}.csv
-                echo '"'"'```'"'"'
-                echo
-                echo "> [!WARNING] "
-                echo "> Do not take GHA benchmark results as face value, always confirm them"
-                echo "> using a dedicated machine, e.g. Jenkins CI."
-            ' | tee /dev/stderr >> "$GITHUB_STEP_SUMMARY"
-        env:
-          FILTER: ${{ inputs.filter }}
-
-      - name: Upload raw benchmark results
-        uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a  # v7.0.1
-        with:
-          name: csv-${{ matrix.system }}
-          path: ${{ matrix.system }}.csv
-
   aggregate-results:
-    needs: build
+    # needs: build
     name: Aggregate benchmark results
     runs-on: ubuntu-slim
     steps:
@@ -174,6 +51,8 @@ jobs:
           pattern: csv-*
           merge-multiple: true
           path: raw-results
+          github-token: ${{ secrets.GH_USER_TOKEN }} # token with actions:read permissions on target repo
+          run-id: 26591497321
 
       - uses: cachix/install-nix-action@96951a368ba55167b55f1c916f7d416bac6505fe  # v31.10.3
         with: