tools: try nix-diff

Author: aduh95

.github/workflows/test-shared.yml

@@ -111,92 +111,63 @@ permissions:
 jobs:
   build-tarball:
     if: github.event.pull_request.draft == false
-    name: ${{ github.event_name == 'workflow_dispatch' && 'Skipped job' || 'Build slim tarball' }}
+    strategy:
+      matrix:
+        install-nix-action: [96951a368ba55167b55f1c916f7d416bac6505fe, 616559265b40713947b9c190a8ff4b507b5df49b]
     runs-on: ubuntu-slim
     steps:
       - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd  # v6.0.2
         if: ${{ github.event_name != 'workflow_dispatch' }}
         with:
           persist-credentials: false
 
-      - name: Make tarball
-        if: ${{ github.event_name != 'workflow_dispatch' }}
+      - uses: cachix/install-nix-action@96951a368ba55167b55f1c916f7d416bac6505fe  # v31.10.3
+        if: ${{ matrix.install-nix-action == '96951a368ba55167b55f1c916f7d416bac6505fe' }}
+        with:
+          extra_nix_config: sandbox = true
+
+      - uses: cachix/install-nix-action@616559265b40713947b9c190a8ff4b507b5df49b  # v31.10.3
+        if: ${{ matrix.install-nix-action == '616559265b40713947b9c190a8ff4b507b5df49b' }}
+        with:
+          extra_nix_config: sandbox = true
+
+      - name: Instantiate derivation
+        id: drv
         run: |
-          export DATESTRING=$(date "+%Y-%m-%d")
-          export COMMIT=$(git rev-parse --short=10 "$GITHUB_SHA")
-          ./configure && make tar -j4 SKIP_XZ=1 SKIP_SHARED_DEPS=1
-        env:
-          DISTTYPE: nightly
+          echo "DRV=$(nix-instantiate -E 'builtins.filter (p: p.pname == "v8") (import ./shell.nix { useSeparateDerivationForV8=true; }).buildInputs')" >> "$GITHUB_OUTPUT"
 
       - name: Upload tarball artifact
-        if: ${{ github.event_name != 'workflow_dispatch' }}
         uses: actions/upload-artifact@bbbca2ddaa5d8feaa63e36b76fdaad77386f024f  # v7.0.0
         with:
-          name: tarballs
-          path: '*.tar.gz'
-          compression-level: 0
+          name: ${{ matrix.install-nix-action }}.drv
+          path: ${{ steps.drv.outputs.DRV }}
 
-  build:
+  nix-diff:
     needs: build-tarball
-    strategy:
-      fail-fast: false
-      matrix:
-        include:
-          - runner: ubuntu-24.04
-            system: x86_64-linux
-          - runner: ubuntu-24.04-arm
-            system: aarch64-linux
-          - runner: macos-15-intel
-            system: x86_64-darwin
-          - runner: macos-latest
-            system: aarch64-darwin
-    name: '${{ matrix.system }}: with shared libraries'
-    runs-on: ${{ matrix.runner }}
+    runs-on: ubuntu-slim
     steps:
-      - uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c  # v8.0.1
-        if: ${{ github.event_name != 'workflow_dispatch' }}
+      - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd  # v6.0.2
         with:
-          name: tarballs
-          path: tarballs
-
-      - name: Extract tarball
-        if: ${{ github.event_name != 'workflow_dispatch' }}
-        run: |
-          tar xzf tarballs/*.tar.gz -C "$RUNNER_TEMP"
-          echo "TAR_DIR=$RUNNER_TEMP/$(basename tarballs/*.tar.gz .tar.gz)" >> "$GITHUB_ENV"
+          persist-credentials: false
+          sparse-checkout: '*.nix'
+          sparse-checkout-cone-mode: false
 
-      - uses: cachix/install-nix-action@96951a368ba55167b55f1c916f7d416bac6505fe  # v31.10.3
+      - name: Download benchmark raw results
+        uses: actions/download-artifact@634f93cb2916e3fdff6788551b99b062d0335ce0  # v5.0.0
         with:
-          extra_nix_config: sandbox = true
+          pattern: csv-*
+          merge-multiple: true
+          path: raw-results
+      - run: ls
 
-      - uses: cachix/cachix-action@1eb2ef646ac0255473d23a5907ad7b04ce94065c  # v17
-        with:
-          name: nodejs
-          authToken: ${{ secrets.CACHIX_AUTH_TOKEN }}
+      # - uses: cachix/install-nix-action@96951a368ba55167b55f1c916f7d416bac6505fe  # v31.10.3
+      #   with:
+      #     extra_nix_config: sandbox = true
 
-      - name: Configure sccache
-        if: github.base_ref == 'main' || github.ref_name == 'main'
-        uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd  # v8.0.0
-        with:
-          script: |
-            core.exportVariable('SCCACHE_GHA_ENABLED', 'on');
-            core.exportVariable('ACTIONS_CACHE_SERVICE_V2', 'on');
-            core.exportVariable('ACTIONS_RESULTS_URL', process.env.ACTIONS_RESULTS_URL || '');
-            core.exportVariable('ACTIONS_RUNTIME_TOKEN', process.env.ACTIONS_RUNTIME_TOKEN || '');
-            core.exportVariable('NIX_SCCACHE', '(import <nixpkgs> {}).sccache');
+      # - name: Benchmark results
+      #   run: |
+      #     nix-shell \
+      #       -I nixpkgs=./tools/nix/pkgs.nix \
+      #       -p nix-diff \
+      #       --run 'nix-diff *.drv'
 
-      - name: Build Node.js and run tests
-        run: |
-          nix-shell \
-            -I "nixpkgs=$TAR_DIR/tools/nix/pkgs.nix" \
-            --pure --keep TAR_DIR --keep FLAKY_TESTS \
-            --keep SCCACHE_GHA_ENABLED --keep ACTIONS_CACHE_SERVICE_V2 --keep ACTIONS_RESULTS_URL --keep ACTIONS_RUNTIME_TOKEN \
-            --arg loadJSBuiltinsDynamically false \
-            --arg useSeparateDerivationForV8 true \
-            --arg ccache "${NIX_SCCACHE:-null}" \
-            --arg devTools '[]' \
-            --arg benchmarkTools '[]' \
-            ${{ endsWith(matrix.system, '-darwin') && '--arg withAmaro false --arg withLief false --arg withSQLite false --arg withFFI false --arg extraConfigFlags ''["--without-inspector" "--without-node-options"]'' \' || '\' }}
-            --run '
-                make -C "$TAR_DIR" run-ci -j4 V=1 TEST_CI_ARGS="-p actions --measure-flakiness 9 --skip-tests=$CI_SKIP_TESTS"
-            ' "$TAR_DIR/shell.nix"