Allow recording of videos at any duration#301
Open
TLAlice wants to merge 1 commit into
Open
Conversation
|
✔️ Deploy Preview for wasm4 ready! 🔨 Explore the source changes: 7085765 🔍 Inspect the deploy log: https://app.netlify.com/sites/wasm4/deploys/61dd85e7c3c79500076f0373 😎 Browse the preview: https://deploy-preview-301--wasm4.netlify.app |
Changed the recordVideo function so that instead of pressing record and then recording for 4 seconds, gameplay starts being recorded upon pressing record until pressing it again
Owner
|
Hi Alice, thanks for the PR! I think we need to keep some sort of maximum timeout for the video recording. Otherwise it's likely that the user will forget to press the record key a second time, which will probably run the browser out of memory and crash the tab 😁 Can you change it to keep the |
Contributor
|
Do we not show any indication that the video is being recored to remind them? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed the recordVideo function so that instead of pressing record and then recording for 4 seconds, gameplay starts being recorded upon pressing record until pressing it again