fix: split setup-node into conditional steps to avoid empty node-version

actions/setup-node prioritizes node-version over node-version-file.
When the matrix value is '.node-version', the previous expression set
node-version to an empty string, which could cause the action to ignore
node-version-file entirely. Split into two steps with if: guards so
node-version is never set to an empty value.

Fixes all instances across build-server.yml, build-and-test-extension.yml,
and build-and-test-client.yml (integration-tests and codeql-path-tests jobs).

Co-authored-by: data-douser <70299490+data-douser@users.noreply.github.com>

Author: Copilot

.github/workflows/build-and-test-client.yml

@@ -102,13 +102,20 @@ jobs:
           cache-dependency-path: 'client/go.sum'
           go-version-file: 'client/go.mod'
 
-      - name: Setup Node.js environment
+      - name: Setup Node.js environment (from .node-version)
+        if: matrix.node == '.node-version'
         uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0
         with:
           cache: 'npm'
-          node-version: ${{ matrix.node != '.node-version' && matrix.node || '' }}
           node-version-file: '.node-version'
 
+      - name: Setup Node.js environment (explicit version)
+        if: matrix.node != '.node-version'
+        uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0
+        with:
+          cache: 'npm'
+          node-version: ${{ matrix.node }}
+
       - name: Install OS dependencies (Ubuntu)
         if: runner.os == 'Linux'
         run: sudo apt-get install -y jq
@@ -214,13 +221,20 @@ jobs:
       - name: Checkout repository
         uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
 
-      - name: Setup Node.js
+      - name: Setup Node.js (from .node-version)
+        if: matrix.node == '.node-version'
         uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0
         with:
           cache: 'npm'
-          node-version: ${{ matrix.node != '.node-version' && matrix.node || '' }}
           node-version-file: '.node-version'
 
+      - name: Setup Node.js (explicit version)
+        if: matrix.node != '.node-version'
+        uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0
+        with:
+          cache: 'npm'
+          node-version: ${{ matrix.node }}
+
       - name: Install server dependencies
         run: npm ci --workspace=server
 

.github/workflows/build-and-test-extension.yml

@@ -41,13 +41,20 @@ jobs:
       - name: Checkout repository
         uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
 
-      - name: Setup Node.js environment
+      - name: Setup Node.js environment (from .node-version)
+        if: matrix.node == '.node-version'
         uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0
         with:
           cache: 'npm'
-          node-version: ${{ matrix.node != '.node-version' && matrix.node || '' }}
           node-version-file: '.node-version'
 
+      - name: Setup Node.js environment (explicit version)
+        if: matrix.node != '.node-version'
+        uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0
+        with:
+          cache: 'npm'
+          node-version: ${{ matrix.node }}
+
       - name: Install dependencies
         run: npm ci --include=optional --ignore-scripts
 

.github/workflows/build-server.yml

@@ -39,13 +39,20 @@ jobs:
       - name: Build Server - Checkout repository
         uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
 
-      - name: Build Server - Setup Node.js environment
+      - name: Build Server - Setup Node.js environment (from .node-version)
+        if: matrix.node == '.node-version'
         uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0
         with:
           cache: 'npm'
-          node-version: ${{ matrix.node != '.node-version' && matrix.node || '' }}
           node-version-file: '.node-version'
 
+      - name: Build Server - Setup Node.js environment (explicit version)
+        if: matrix.node != '.node-version'
+        uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0
+        with:
+          cache: 'npm'
+          node-version: ${{ matrix.node }}
+
       - name: Build Server - Install dependencies
         run: npm ci --include=optional --ignore-scripts
         working-directory: .