fix: `ql-mcp` server must handle vscode workspace folder changes by data-douser · Pull Request #196 · advanced-security/codeql-development-mcp-server

data-douser · 2026-03-30T00:43:29Z

📝 Update Information

Primitive Details

Type: Both
Name: McpProvider / VS Code extension workspace folder handling
Update Category: Bug Fix
Impact Scope: Moderate

Update Metadata

Breaking Changes: No
API Compatibility: Maintained
Performance Impact: Improved — extension version is now cached to avoid repeated synchronous readFileSync calls

🎯 Changes Description

Current Behavior

When workspace folders were added or removed, fireDidChange() notified VS Code that the MCP server definitions changed, causing it to stop the running server. Because the returned McpStdioServerDefinition had the same version as before, VS Code did not restart the ql-mcp server, leaving it in an inconsistent, partially running state. Additionally, requestRestart() did not invalidate the environment cache, meaning a server restart could reuse a stale cached environment. The multi-root workspace test fixture contained a machine-specific absolute temp folder path causing non-reproducible test failures on other machines and CI.

Updated Behavior

The extension now correctly invalidates its environment cache on workspace folder changes and uses a monotonically increasing revision counter (via requestRestart()) to ensure VS Code reliably detects version changes and restarts the server when needed. requestRestart() now internally calls envBuilder.invalidate(), so the env cache is always fresh on restart. The version suffix uses the +rN format (e.g. 2.25.1+r1) to keep the base version shape intact. McpProvider caches the extension version in its constructor to avoid repeated synchronous readFileSync calls on every getEffectiveVersion() invocation. Integration test spy setup uses try/finally to guarantee restoration even if assertions throw. The integration test for folder-add now populates the env cache before mutating workspace folders, properly verifying that cache invalidation occurs on onDidChangeWorkspaceFolders. The unit test for the "latest version" case re-instantiates McpProvider after configuring the getExtensionVersion mock so the constructor picks up the correct value.

Motivation

The previous implementation left the ql-mcp server in a broken state after workspace folder changes. requestRestart() could trigger a restart while still reusing a stale cached environment. Repeated synchronous I/O (readFileSync of package.json) on every definition query unnecessarily blocked the extension host. Test mocks leaked state between tests when spy restoration was not guaranteed. The folder-add integration test could pass vacuously (without ever populating the cache before the add), masking a real regression. The unit test for the "latest version" path set the getExtensionVersion mock after the provider was already constructed, giving a false sense that the test was configuring the base version.

🔄 Before vs. After Comparison

Functionality Changes

// BEFORE: Workspace folder changes triggered fireDidChange() with same version,
// leaving server stopped but not restarted
vscode.workspace.onDidChangeWorkspaceFolders(() => {
  this._onDidChangeDefinitions.fire();
});

// AFTER: Workspace folder changes only invalidate env cache; requestRestart()
// bumps the revision/version so VS Code restarts the server on config changes
vscode.workspace.onDidChangeWorkspaceFolders(() => {
  envBuilder.invalidate();
});

// BEFORE: requestRestart() only bumped revision — callers had to invalidate env separately
requestRestart(): void {
  this._revision++;
  this._onDidChange.fire();
}

// AFTER: requestRestart() invalidates env cache before bumping revision
requestRestart(): void {
  this.envBuilder.invalidate();
  this._revision++;
  this._onDidChange.fire();
}

// BEFORE: Extension version read synchronously on every definition query
private getEffectiveVersion(): string {
  const base = this.serverManager.getVersion() ?? this.serverManager.getExtensionVersion();
  // ...
}

// AFTER: Extension version cached once in constructor
constructor(...) {
  this._extensionVersion = serverManager.getExtensionVersion();
}
private getEffectiveVersion(): string {
  const base = this.serverManager.getVersion() ?? this._extensionVersion;
  // ...
}

// BEFORE (integration test): build() called only after folder add — cache invalidation untested
await addWorkspaceFolder(vscode.Uri.file(tempDir));
const env = await envBuilder.build();

// AFTER (integration test): cache populated before add, precondition asserted, then verified post-add
const envBefore = await envBuilder.build();
assert.ok(!beforeFoldersEnv.includes(tempDir), 'Precondition: tempDir absent before add');
await addWorkspaceFolder(vscode.Uri.file(tempDir));
const envAfter = await envBuilder.build();
assert.ok(workspaceFoldersEnv.includes(tempDir), '...');

// BEFORE (unit test): mock set after provider construction — no effect on cached version
serverManager.getExtensionVersion.mockReturnValue('2.25.1');
// provider already constructed in beforeEach — cached value unaffected

// AFTER (unit test): re-instantiate provider after setting mock
serverManager.getExtensionVersion.mockReturnValue('2.25.1');
provider = new McpProvider(serverManager, envBuilder, logger);

API Changes

// New method added to McpProvider (invalidates env cache and bumps version internally)
requestRestart(): void;

Output Format Changes

// BEFORE: Version string was static (e.g., "1.2.3") or used dot-suffix (e.g., "1.2.3.1")
{ "version": "1.2.3" }

// AFTER: Version string uses +rN suffix to keep base version shape intact
{ "version": "1.2.3+r1" }

🧪 Testing & Validation

Test Coverage Updates

Existing Tests: All existing tests continue to pass
New Test Cases: Added tests for version bumping, +rN revision suffixing, env cache invalidation, and workspace folder change handling
Regression Tests: Added tests to prevent regression of the server-not-restarting issue; integration test now correctly verifies cache invalidation by populating the cache before the folder mutation
Edge Case Tests: Tests for pinned/unpinned versions, soft/hard signals, event firing, spy cleanup via try/finally, and McpProvider constructor caching behavior

Validation Scenarios

Backward Compatibility: Existing workspace configurations continue to work without breaking changes
New Functionality: requestRestart() correctly invalidates env cache, increments revision, and fires change event; version string changes on each call using +rN format
Error Handling: Cleanup failures in integration tests are caught and do not fail tests; vi.spyOn() with try/finally ensures mock cleanup even if assertions throw
Performance: Extension version cached once in constructor, eliminating repeated synchronous readFileSync on every definition query
Test Correctness: Folder-add integration test populates cache before mutating workspace, ensuring cache invalidation is actually exercised; unit test re-instantiates provider so the constructor-cached version reflects the configured mock

Test Results

Unit Tests: All pass (131 tests)
Integration Tests: All pass
Manual Testing: Validated with real workspace folder add/remove scenarios
Performance Testing: No regressions detected

📋 Implementation Details

Files Modified

Core Implementation: extensions/vscode/src/server/mcp-provider.ts
Supporting Libraries: extensions/vscode/src/extension.ts
Tests: extensions/vscode/test/server/mcp-provider.test.ts, extensions/vscode/test/extension.test.ts, extensions/vscode/test/suite/workspace-folder-change.integration.test.ts
Fixtures: extensions/vscode/test/fixtures/multi-root-workspace/test.code-workspace (removed machine-specific temp folder entry)

Code Changes Summary

Algorithm Improvements: requestRestart() atomically invalidates env cache and bumps revision; version suffix uses +rN format; extension version cached in constructor
Error Handling: Integration test cleanup wrapped in try/catch; fs.rmdirSync replaced with fs.rmSync; spy restoration guaranteed via try/finally; duplicate assertion removed from removeWorkspaceFolder
Performance Optimization: Extension version read once at construction time instead of on every getEffectiveVersion() call
Type Safety: requestRestart() method properly typed and self-contained
Input Validation: Path delimiter splitting for CODEQL_MCP_WORKSPACE_FOLDERS assertions; updateWorkspaceFolders return value asserted before awaiting change promise
Test Correctness: Integration test for folder-add now pre-populates env cache and asserts precondition before mutating workspace; unit test for "latest version" re-instantiates McpProvider after configuring getExtensionVersion mock

Dependencies

No New Dependencies: Update uses existing dependencies only

🔍 Quality Improvements

Bug Fixes (if applicable)

Issue: ql-mcp server stopped but not restarted after workspace folder changes; requestRestart() did not invalidate env cache as documented; version suffix produced non-semver strings; test fixture contained machine-specific path; test mock leaked state; duplicate assertion in removeWorkspaceFolder; extension version read synchronously on every query; integration test for folder-add did not pre-populate cache (vacuous test); unit test configured getExtensionVersion mock after provider construction (no effect)
Root Cause: fireDidChange() called with identical version string; env invalidation was caller's responsibility but undocumented; .N dot-suffix breaks semver shape; fixture committed with absolute temp path; direct property assignment had no restore mechanism; copy-paste error introduced duplicate assertion; getExtensionVersion() called repeatedly without caching; build() called for the first time after the folder add (cache never populated before mutation); mock changed after constructor already captured the value
Solution: requestRestart() calls envBuilder.invalidate() internally; version suffix changed to +rN; machine-specific entry removed from fixture; vi.spyOn() with try/finally replaces direct assignment; duplicate assertion removed; extension version cached in constructor field; integration test calls build() before addWorkspaceFolder() and asserts precondition; unit test re-instantiates McpProvider after setting mock
Prevention: Unit tests verify env invalidation and version changes on each requestRestart() call; regex patterns enforce +rN format; fixture limited to repo-relative folders; precondition assertion in integration test ensures the test cannot pass vacuously

Performance Improvements

Baseline Performance: getExtensionVersion() (readFileSync of package.json) called on every provideMcpServerDefinitions() and getEffectiveVersion() invocation
Improved Performance: Extension version read once in constructor and cached; subsequent calls use in-memory field lookup
Optimization Techniques: Constructor-time caching of immutable extension metadata

Code Quality Enhancements

Readability: Clearer separation between soft (env invalidation only) and hard (env invalidation + version bump + restart signal) update signals
Maintainability: requestRestart() is now self-contained — callers cannot forget to invalidate the env cache
Testability: Integration test correctly exercises cache invalidation by pre-populating before mutation; unit test accurately configures constructor input via mock-before-construct pattern
Reusability: requestRestart() can be safely called from any handler that needs to force a server restart with fresh environment

🔗 References

Validation Materials

Test Cases: mcp-provider.test.ts (unit), extension.test.ts (unit), workspace-folder-change.integration.test.ts (integration)

🚀 Compatibility & Migration

Backward Compatibility

Fully Compatible: No breaking changes

API Evolution

Enhanced Parameters: requestRestart() method added to McpProvider; now also invalidates env cache internally
Improved Responses: Server version now uses +rN suffix for reliable change detection while keeping base version shape intact
Maintained Contracts: Core API contracts preserved

👥 Review Guidelines

For Reviewers

Please verify:

⚠️ NO UNRELATED FILES: Machine-specific fixture entry removed; no temp or output files
⚠️ BACKWARD COMPATIBILITY: Existing functionality preserved
Functionality: Workspace folder changes correctly invalidate env cache; config changes trigger server restart via requestRestart() (which now handles env invalidation internally); extension version cached to avoid repeated sync I/O
Test Coverage: All existing tests pass; new unit and integration tests added; spy cleanup guaranteed via try/finally; integration test correctly pre-populates cache before folder mutation; unit test re-instantiates provider after mock configuration
Code Quality: Maintains or improves code quality

Testing Instructions

# Full test suite
npm install
npm run build
npm test

# Extension unit tests
cd extensions/vscode
npm run test:coverage

# Code quality checks
npm run lint
npm run format
npm run type-check

Validation Checklist

Regression Testing: Verify no existing functionality is broken
New Feature Testing: Validate requestRestart() invalidates env cache, increments revision, and changes version string to +rN format
Performance Testing: Verify extension version is cached (no repeated readFileSync per query)
Integration Testing: Verify environment cache is rebuilt after workspace mutations; integration test pre-populates cache before folder add to exercise invalidation
Unit Test Accuracy: Confirm unit test for "latest version" re-instantiates provider after mock setup so constructor-cached value is correct
Fixture Testing: Confirm test fixture loads correctly on all platforms without machine-specific paths

📊 Impact Assessment

Performance Impact

Execution Time: Reduced per-query overhead by eliminating synchronous readFileSync on every getEffectiveVersion() call

Server Impact

Startup Time: No significant impact on server startup
Runtime Stability: Improved — server is no longer left in a broken state after workspace folder changes
Resource Usage: Improved — extension version read once at startup instead of on every definition query
Concurrent Usage: Safe for concurrent access

AI Assistant Impact

Improved Reliability: More reliable MCP server lifecycle in dynamic workspace scenarios
Enhanced User Experience: Server correctly restarts with a fresh environment when workspace configuration changes

🔄 Deployment Strategy

Rollout Considerations

Safe Deployment: Can be deployed safely to production
Monitoring: Standard VS Code extension telemetry applies

Update Methodology: This update follows best practices:

✅ Comprehensive backward compatibility analysis
✅ Thorough testing of all changes
✅ Performance impact assessment
✅ Clear documentation of changes
✅ Robust error handling improvements
✅ Maintained code quality standards

When workspace folders were added or removed, fireDidChange() notified VS Code that the MCP server definitions changed, causing it to stop the running server. However, because the returned McpStdioServerDefinition had the same version as before, VS Code did not restart the server. Add a monotonically increasing revision counter to McpProvider that increments on each fireDidChange() call and is appended to the version string (e.g. 2.25.1.1, 2.25.1.2). This signals VS Code that the definition has genuinely changed and triggers a server restart with the updated environment instead of only stopping the server. - Add _revision counter and getEffectiveVersion() to McpProvider - Add 4 unit tests for version-bumping behaviour - Add integration test suite for workspace folder change scenarios

github-actions · 2026-03-30T00:43:42Z

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA 9b6d56c.

Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

Scanned Files

None

Copilot

Pull request overview

This PR fixes a VS Code MCP lifecycle issue where workspace folder changes would stop (but not restart) the ql-mcp server by ensuring the provided server definition’s version changes on each definition refresh.

Changes:

Add a monotonically increasing revision counter to McpProvider and append it to the effective server definition version after fireDidChange().
Add unit tests validating version bumping behavior across fireDidChange() calls.
Add an extension-host integration test suite covering workspace folder add/remove scenarios and env refresh.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File	Description
extensions/vscode/src/server/mcp-provider.ts	Adds `_revision` and computes an “effective” version that changes after `fireDidChange()` to force VS Code to restart the server.
extensions/vscode/test/server/mcp-provider.test.ts	Adds unit tests verifying version changes and revision suffixing for pinned/latest cases.
extensions/vscode/test/suite/workspace-folder-change.integration.test.ts	Adds integration coverage for workspace-folder-driven definition changes and environment refresh behavior.

Comments suppressed due to low confidence (2)

extensions/vscode/test/suite/workspace-folder-change.integration.test.ts:201

fs.rmdirSync is deprecated in newer Node versions. Prefer fs.rmSync(tempDir, { recursive: true, force: true }) here as well (and wrap in try/catch if you want best-effort cleanup).

    if (!added) {
      fs.rmdirSync(tempDir);
      this.skip();

extensions/vscode/test/suite/workspace-folder-change.integration.test.ts:132

The comment says Mocha's timeout is 60s, but the test runner sets Mocha's timeout to 30s. Either update this comment or set a longer timeout for this test to avoid confusion / unexpected timeouts on slow CI.

    // Listen for the onDidChangeMcpServerDefinitions event.
    // Mocha's test timeout (60 s) handles the failure case.
    const changePromise = new Promise<void>((resolve) => {

…#169)

- Invalidate cached environment when workspace folders change so the next server start picks up updated folder list - getEffectiveVersion() always returns a concrete string (never undefined) so VS Code has a reliable baseline for version comparison - Add multi-root workspace integration tests verifying environment correctness (CODEQL_MCP_WORKSPACE_FOLDERS includes/excludes folders) - Add unit test for workspace folder change handler behavior - Add unit test for always-defined version string - Add multiRoot test profile with 4 workspace folders

Copilot

Pull request overview

Copilot reviewed 7 out of 9 changed files in this pull request and generated 2 comments.

Agent-Logs-Url: https://github.com/advanced-security/codeql-development-mcp-server/sessions/bc6e5960-6b48-4be3-addb-49a4f14b6efa Co-authored-by: data-douser <70299490+data-douser@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 7 out of 9 changed files in this pull request and generated 3 comments.

data-douser · 2026-03-30T13:51:57Z

@copilot apply changes based on the comments in this thread

… vi.spyOn cleanup Agent-Logs-Url: https://github.com/advanced-security/codeql-development-mcp-server/sessions/b3b84dce-0b52-4c7d-9391-014500df1b9a Co-authored-by: data-douser <70299490+data-douser@users.noreply.github.com>

Copilot · 2026-03-30T14:14:06Z

@copilot apply changes based on the comments in this thread

Applied all changes from the review thread in commit a4ebae2:

mcp-provider.ts (lines 52–68): requestRestart() now calls this.envBuilder.invalidate() before bumping the revision, so the docstring ("fresh environment") is now accurate. Callers no longer need to invalidate separately.
mcp-provider.ts (lines 117–125): Switched the revision suffix from .N (e.g. 2.25.1.1) to +rN (e.g. 2.25.1+r1), matching the PR description and keeping the base version shape intact.
extension.ts: Removed the now-redundant envBuilder.invalidate() call from the config-change handler since requestRestart() handles it.
extension.test.ts (lines 178–181): Replaced the direct property assignment with vi.spyOn(vscode.workspace, 'onDidChangeWorkspaceFolders') and added spy.mockRestore() at the end to prevent state leakage between tests.
mcp-provider.test.ts: Updated regex patterns to +rN format and added a test verifying envBuilder.invalidate is called by requestRestart().

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

marketplace.visualstudio.com
- Triggering command: /home/REDACTED/work/codeql-development-mcp-server/codeql-development-mcp-server/extensions/vscode/.vscode-test/vscode-linux-x64-1.113.0/bin/../code /home/REDACTED/work/codeql-development-mcp-server/codeql-development-mcp-server/extensions/vscode/.vscode-test/vscode-linux-x64-1.113.0/bin/../code /home/REDACTED/work/codeql-development-mcp-server/codeql-development-mcp-server/extensions/vscode/.vscode-test/vscode-linux-x64-1.113.0/bin/../resources/app/out/cli.js --extensions-dir=/home/REDACTED/work/codeql-development-mcp-server/codeql-development-mcp-server/extensions/vscode/.vscode-test/extensions --user-data-dir=/home/REDACTED/work/codeql-development-mcp-server/codeql-development-mcp-server/extensions/vscode/.vscode-test/user-data --install-extension GitHub.vscode-codeql (dns block)
update.code.visualstudio.com
- Triggering command: /opt/hostedtoolcache/node/24.13.0/x64/bin/node node scripts/download-vscode.js (dns block)
- Triggering command: /opt/hostedtoolcache/node/24.13.0/x64/bin/node node /home/REDACTED/work/codeql-development-mcp-server/codeql-development-mcp-server/node_modules/.bin/vscode-test (dns block)
www.vscode-unpkg.net
- Triggering command: /home/REDACTED/work/codeql-development-mcp-server/codeql-development-mcp-server/extensions/vscode/.vscode-test/vscode-linux-x64-1.113.0/bin/../code /home/REDACTED/work/codeql-development-mcp-server/codeql-development-mcp-server/extensions/vscode/.vscode-test/vscode-linux-x64-1.113.0/bin/../code /home/REDACTED/work/codeql-development-mcp-server/codeql-development-mcp-server/extensions/vscode/.vscode-test/vscode-linux-x64-1.113.0/bin/../resources/app/out/cli.js --extensions-dir=/home/REDACTED/work/codeql-development-mcp-server/codeql-development-mcp-server/extensions/vscode/.vscode-test/extensions --user-data-dir=/home/REDACTED/work/codeql-development-mcp-server/codeql-development-mcp-server/extensions/vscode/.vscode-test/user-data --install-extension GitHub.vscode-codeql (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

Copilot

Pull request overview

Copilot reviewed 7 out of 9 changed files in this pull request and generated 1 comment.

…on.test.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Nathan Randall <70299490+data-douser@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 7 out of 9 changed files in this pull request and generated 4 comments.

Comments suppressed due to low confidence (1)

extensions/vscode/test/suite/workspace-folder-change.integration.test.ts:67

removeWorkspaceFolder() has the same listener-leak risk as addWorkspaceFolder(): it subscribes to onDidChangeWorkspaceFolders before verifying updateWorkspaceFolders returned true. If updateWorkspaceFolders returns false, the thrown assertion leaves the event subscription active. Restructure to only subscribe after a successful update or ensure disposal on failure.

async function removeWorkspaceFolder(fsPath: string): Promise<void> {
  const folders = vscode.workspace.workspaceFolders ?? [];
  const idx = folders.findIndex((f) => f.uri.fsPath === fsPath);
  if (idx < 0) return;
  const changePromise = waitForWorkspaceFolderChange();
  const ok = vscode.workspace.updateWorkspaceFolders(idx, 1);
  assert.ok(ok, 'updateWorkspaceFolders (remove) returned false');
  assert.ok(ok, 'updateWorkspaceFolders (remove) returned false');
  await changePromise;

data-douser · 2026-03-30T16:48:45Z

@copilot apply changes based on the comments in this thread

…sion version Agent-Logs-Url: https://github.com/advanced-security/codeql-development-mcp-server/sessions/28160745-507f-46aa-b350-6fd6d19315ba Co-authored-by: data-douser <70299490+data-douser@users.noreply.github.com>

Copilot · 2026-03-30T16:55:40Z

@copilot apply changes based on the comments in this thread

Applied all three changes from the review thread in commit 5e06cd6:

workspace-folder-change.integration.test.ts:66: Removed the duplicate assert.ok(ok, 'updateWorkspaceFolders (remove) returned false') assertion.
extension.test.ts:182-205: Wrapped the test body in try/finally so spy.mockRestore() is guaranteed to run even if an assertion throws.
mcp-provider.ts: Cached the extension version in the constructor (this._extensionVersion = serverManager.getExtensionVersion()). getEffectiveVersion() now uses this._extensionVersion instead of calling serverManager.getExtensionVersion() on every invocation, eliminating the repeated readFileSync calls.

Copilot

Pull request overview

Copilot reviewed 7 out of 9 changed files in this pull request and generated 2 comments.

data-douser · 2026-03-30T19:14:21Z

@copilot apply changes based on the comments in this thread

…vider after mock change Agent-Logs-Url: https://github.com/advanced-security/codeql-development-mcp-server/sessions/a42c54f5-5445-42e7-bad8-f86e1aa717f7 Co-authored-by: data-douser <70299490+data-douser@users.noreply.github.com>

Copilot · 2026-03-30T19:20:35Z

@copilot apply changes based on the comments in this thread

Applied both changes from the review thread in commit 9b6d56c:

workspace-folder-change.integration.test.ts (Test 1): Now calls envBuilder.build() before addWorkspaceFolder() to populate the cache first, asserts the tempDir is absent as a precondition, then adds the folder and verifies it appears in a subsequent build() — properly testing cache invalidation on folder-add.
mcp-provider.test.ts:121: Added provider = new McpProvider(serverManager, envBuilder, logger) after setting serverManager.getExtensionVersion.mockReturnValue('2.25.1'), so the constructor picks up the configured value rather than the already-cached one from beforeEach.

data-douser self-assigned this Mar 30, 2026

data-douser added the bug Something isn't working label Mar 30, 2026

Copilot AI review requested due to automatic review settings March 30, 2026 00:43

Copilot started reviewing on behalf of data-douser March 30, 2026 00:44 View session

Copilot AI reviewed Mar 30, 2026

View reviewed changes

data-douser and others added 3 commits March 30, 2026 06:42

SqliteStore backend + annotation, audit, and query result cache tools (…

ecb2acc

…#169)

Merge branch 'main' into dd/bug-fixes/1

e0e28c9

data-douser requested a review from Copilot March 30, 2026 12:50

Copilot started reviewing on behalf of data-douser March 30, 2026 12:51 View session

Copilot AI reviewed Mar 30, 2026

View reviewed changes

Comment thread extensions/vscode/test/fixtures/multi-root-workspace/test.code-workspace Outdated

Comment thread extensions/vscode/src/extension.ts

Copilot started work on behalf of data-douser March 30, 2026 12:57 View session

fix: remove machine-specific temp folder from workspace fixture

28f1776

Agent-Logs-Url: https://github.com/advanced-security/codeql-development-mcp-server/sessions/bc6e5960-6b48-4be3-addb-49a4f14b6efa Co-authored-by: data-douser <70299490+data-douser@users.noreply.github.com>

Copilot finished work on behalf of data-douser March 30, 2026 13:11

data-douser requested a review from Copilot March 30, 2026 13:38

Copilot started reviewing on behalf of data-douser March 30, 2026 13:39 View session

Copilot AI reviewed Mar 30, 2026

View reviewed changes

Comment thread extensions/vscode/test/extension.test.ts Outdated

Comment thread extensions/vscode/src/server/mcp-provider.ts

Comment thread extensions/vscode/src/server/mcp-provider.ts

Copilot started work on behalf of data-douser March 30, 2026 13:52 View session

Copilot finished work on behalf of data-douser March 30, 2026 14:18

data-douser marked this pull request as ready for review March 30, 2026 15:28

data-douser requested review from a team and enyil as code owners March 30, 2026 15:28

Copilot AI review requested due to automatic review settings March 30, 2026 15:28

Copilot started reviewing on behalf of data-douser March 30, 2026 15:29 View session

Copilot AI reviewed Mar 30, 2026

View reviewed changes

Comment thread extensions/vscode/test/suite/workspace-folder-change.integration.test.ts Outdated

Update extensions/vscode/test/suite/workspace-folder-change.integrati…

a576b4c

…on.test.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Nathan Randall <70299490+data-douser@users.noreply.github.com>

data-douser changed the title ~~fix: restart ql-mcp server on vscode workspace folder changes~~ fix: ql-mcp server must handle vscode workspace folder changes Mar 30, 2026

Update extensions/vscode/test/suite/workspace-folder-change.integrati…

dd80dc5

…on.test.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Nathan Randall <70299490+data-douser@users.noreply.github.com>

Copilot AI review requested due to automatic review settings March 30, 2026 16:43

Copilot started reviewing on behalf of data-douser March 30, 2026 16:43 View session

Copilot AI reviewed Mar 30, 2026

View reviewed changes

Comment thread extensions/vscode/test/suite/workspace-folder-change.integration.test.ts Outdated

Comment thread extensions/vscode/test/extension.test.ts Outdated

Comment thread extensions/vscode/src/server/mcp-provider.ts

Comment thread extensions/vscode/src/extension.ts

Copilot started work on behalf of data-douser March 30, 2026 16:48 View session

Copilot finished work on behalf of data-douser March 30, 2026 16:59

Merge branch 'main' into dd/bug-fixes/1

a9669d7

Copilot AI review requested due to automatic review settings March 30, 2026 18:56

Copilot started reviewing on behalf of data-douser March 30, 2026 18:57 View session

Copilot AI reviewed Mar 30, 2026

View reviewed changes

Comment thread extensions/vscode/test/suite/workspace-folder-change.integration.test.ts Outdated

Comment thread extensions/vscode/test/server/mcp-provider.test.ts

Copilot started work on behalf of data-douser March 30, 2026 19:14 View session

Copilot finished work on behalf of data-douser March 30, 2026 19:24

data-douser merged commit cb2d28f into main Mar 30, 2026
10 checks passed

data-douser deleted the dd/bug-fixes/1 branch March 30, 2026 19:54

Conversation

data-douser commented Mar 30, 2026 • edited by Copilot AI Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📝 Update Information

Primitive Details

Update Metadata

🎯 Changes Description

Current Behavior

Updated Behavior

Motivation

🔄 Before vs. After Comparison

Functionality Changes

API Changes

Output Format Changes

🧪 Testing & Validation

Test Coverage Updates

Validation Scenarios

Test Results

📋 Implementation Details

Files Modified

Code Changes Summary

Dependencies

🔍 Quality Improvements

Bug Fixes (if applicable)

Performance Improvements

Code Quality Enhancements

🔗 References

Validation Materials

🚀 Compatibility & Migration

Backward Compatibility

API Evolution

👥 Review Guidelines

For Reviewers

Testing Instructions

Validation Checklist

📊 Impact Assessment

Performance Impact

Server Impact

AI Assistant Impact

🔄 Deployment Strategy

Rollout Considerations

Uh oh!

github-actions bot commented Mar 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Dependency Review

Snapshot Warnings

Scanned Files

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

data-douser commented Mar 30, 2026

Uh oh!

Copilot AI commented Mar 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

data-douser commented Mar 30, 2026 •

edited by Copilot AI

Loading

github-actions bot commented Mar 30, 2026 •

edited

Loading

Copilot AI commented Mar 30, 2026 •

edited

Loading