-
Notifications
You must be signed in to change notification settings - Fork 2
Updates for v2.25.1-next.2 prerelease
#204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 17 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
ae1eaf7
Initial plan
Copilot 7fd8da3
Fix bugs 1-5 and implement design improvements 2, 3, 5
Copilot ddd4de4
Design 1: Populate query_results_cache from database_analyze results
Copilot 7854829
Address PR review feedback and fix failing integration tests
Copilot ea5a11c
Update versions & CHANGELOG for v2.25.1-next.2 (#200)
data-douser 7a590b4
Fix bqrs_interpret: auto-resolve --source-location-prefix from databa…
Copilot 1f75bdc
Fix bqrs_interpret: defensive coercion for file parameter array/brack…
Copilot 886b3f8
Fix CHANGELOG version reference and use explicit null check for findi…
Copilot 1eb9afa
Improve cli-tool-registry code and testing
data-douser 2cfe94b
Design 3 TDD: add cache lookup tests for cacheKey/queryName/language/…
Copilot 24ba5d2
Address review round 4: empty string edge cases, process.env guards, …
Copilot d42fe5b
Sync server/dist/codeql-development-mcp-server.js*
data-douser 7fedace
SARIF analysis tools and cache model improvements
data-douser c822c89
WIP mcp tool improvements
data-douser 78e0e55
feat: backwards-compatible ql-mcp server pack installs for matching C…
Copilot 5655ba1
refactor: improve parseVersionString to use last version match on fir…
Copilot d5e0cc0
Update MCP prompts & resources + CHANGELOG
data-douser b12fc0d
Sync package-lock.json & server/dist/**
data-douser 1edaa08
Fixes for PR review feedback
data-douser 6a682d6
chore: use SPDX LicenseRef-CodeQL-Terms for license compliance
data-douser a5e5460
Address latest PR review feedback
data-douser 073ca71
Update CHANGELOG.md
data-douser a954543
Improve SARIF grouped-by-rule alerts processing
data-douser File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 changes: 10 additions & 0 deletions
10
...rimitives/prompts/compare_overlapping_alerts/basic_comparison/after/monitoring-state.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| { | ||
| "sessions": [ | ||
| { | ||
| "expectedContentPatterns": [ | ||
| "sarif_list_rules", | ||
| "sarif_compare_alerts" | ||
| ] | ||
| } | ||
| ] | ||
| } |
6 changes: 6 additions & 0 deletions
6
...imitives/prompts/compare_overlapping_alerts/basic_comparison/before/monitoring-state.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| { | ||
| "sessions": [], | ||
| "parameters": { | ||
| "sarifPathA": "nonexistent/path/to/results.sarif" | ||
|
data-douser marked this conversation as resolved.
Outdated
|
||
| } | ||
| } | ||
2 changes: 1 addition & 1 deletion
2
client/integration-tests/primitives/tools/codeql_bqrs_info/json_format/test-config.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,7 @@ | ||
| { | ||
| "toolName": "codeql_bqrs_info", | ||
| "arguments": { | ||
| "files": ["client/integration-tests/primitives/tools/codeql_bqrs_info/json_format/before/results.bqrs"], | ||
| "file": "client/integration-tests/primitives/tools/codeql_bqrs_info/json_format/before/results.bqrs", | ||
| "format": "json" | ||
| } | ||
| } |
21 changes: 21 additions & 0 deletions
21
.../integration-tests/primitives/tools/sarif_compare_alerts/sink_overlap/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| # Integration Test: sarif_compare_alerts - sink_overlap | ||
|
|
||
| ## Purpose | ||
|
|
||
| Validates that the `sarif_compare_alerts` tool correctly compares code locations | ||
| between two SARIF alerts from different rules to detect sink-level overlap. | ||
|
|
||
| ## Inputs | ||
|
|
||
| - `test-input.sarif`: A multi-rule SARIF file where `js/sql-injection` result 0 | ||
| and `js/missing-rate-limiting` result 0 both reference `src/routes/users.js` | ||
| but at different line ranges — so they should NOT have sink overlap. | ||
|
|
||
| ## Expected Behavior | ||
|
|
||
| The tool returns a comparison result with: | ||
|
|
||
| - `overlaps`: false (the two alerts are at different lines in the same file) | ||
| - `overlapMode`: "sink" | ||
| - Alert details for both A and B (ruleId, location, message) | ||
| - Empty `sharedLocations` array |
5 changes: 5 additions & 0 deletions
5
...tion-tests/primitives/tools/sarif_compare_alerts/sink_overlap/after/monitoring-state.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| { | ||
| "toolName": "sarif_compare_alerts", | ||
| "success": true, | ||
| "description": "Successfully compared alert locations for sink overlap" | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.