Fix devcontainer Node image to match >=25.6.0 engine requirement#239
Closed
Fix devcontainer Node image to match >=25.6.0 engine requirement#239
Conversation
Updates the minimum required "engines.vscode" version from "^1.110.0" to "^1.115.0" in order to align with newer @types/vscode.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Nathan Randall <70299490+data-douser@users.noreply.github.com>
…view-comments Co-authored-by: data-douser <70299490+data-douser@users.noreply.github.com>
… >=25.6.0 compatibility Agent-Logs-Url: https://github.com/advanced-security/codeql-development-mcp-server/sessions/eeb2bb66-bcd2-47d2-88f3-532a9401b22d Co-authored-by: data-douser <70299490+data-douser@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix code for all comments in review thread
Fix devcontainer Node image to match >=25.6.0 engine requirement
Apr 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #237 bumped the repo-wide Node engine requirement to
>=25.6.0but left.devcontainer/devcontainer.jsonon thetypescript-node:24image, breaking the devcontainer for contributors.📝 Update Information
Primitive Details
.devcontainer/devcontainer.json✅ ALLOWED FILES:
package.json,.devcontainer/devcontainer.json)README.md, server docs)🚫 FORBIDDEN FILES:
Rationale: This PR should contain only the files necessary to update and test the primitive.
🚨 PRs that include forbidden files will be rejected and must be revised.
🛑 MANDATORY PR VALIDATION CHECKLIST
BEFORE SUBMITTING THIS PR, CONFIRM:
Update Metadata
🎯 Changes Description
Current Behavior
Devcontainer uses
mcr.microsoft.com/devcontainers/typescript-node:24, providing Node 24.x — incompatible with the>=25.6.0engine constraint set in PR #237.Updated Behavior
Devcontainer uses
typescript-node:25, providing Node 25.x which satisfies>=25.6.0.Motivation
Devcontainer must track the minimum supported Node version so contributors get a working environment out of the box.
🔄 Before vs. After Comparison
Functionality Changes
API Changes
None.
Output Format Changes
None.
🧪 Testing & Validation
Test Coverage Updates
Validation Scenarios
Test Results
package.jsonengines (>=25.6.0) and devcontainer image (typescript-node:25) are consistent📋 Implementation Details
Files Modified
.devcontainer/devcontainer.json— image tag:24→:25Code Changes Summary
Dependencies
🔍 Quality Improvements
Bug Fixes (if applicable)
typescript-node:25Performance Improvements
N/A
Code Quality Enhancements
🔗 References
Related Issues/PRs
>=25.6.0requirement)External References
mcr.microsoft.com/devcontainers/typescript-nodeValidation Materials
package.jsonengines.node: ">=25.6.0"matches devcontainer image tag:25🚀 Compatibility & Migration
Backward Compatibility
Breaking Changes (if any)
None.
API Evolution
👥 Review Guidelines
For Reviewers
Please verify:
Testing Instructions
Validation Checklist
engines.nodeand devcontainer image tag are aligned📊 Impact Assessment
Performance Impact
Server Impact
AI Assistant Impact
🔄 Deployment Strategy
Rollout Considerations
Post-Deployment Validation
Update Methodology: This update follows best practices: