-
Notifications
You must be signed in to change notification settings - Fork 2
Improve MCP server integrations with codeql execute *-server servers
#29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
76a139b
Add CodeQL background server manager and LSP tools
data-douser 0202522
Fix server lifecycle bugs and replace hard-coded startup delays
data-douser b20db0b
Fix CI failures and improve LSP tool reliability
data-douser e561fa4
Address PR review comments & fix integration tests
data-douser d375e41
Fixes for codeql_lsp_* tool integration tests
data-douser a30bc49
Address PR review comments from review #3773277390
data-douser a58953d
Address code-quality PR review feedback
data-douser File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
35 changes: 0 additions & 35 deletions
35
...mitives/tools/codeql_language_server_eval/semantic_validation/after/monitoring-state.json
This file was deleted.
Oops, something went wrong.
3 changes: 0 additions & 3 deletions
3
...itives/tools/codeql_language_server_eval/semantic_validation/before/monitoring-state.json
This file was deleted.
Oops, something went wrong.
22 changes: 22 additions & 0 deletions
22
...gration-tests/primitives/tools/codeql_lsp_completion/basic_completion/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| # `codeql_lsp_completion/basic_completion` | ||
|
|
||
| ## PURPOSE | ||
|
|
||
| Tests that `codeql_lsp_completion` returns targeted completion items for a | ||
| member-access expression. The cursor is positioned after `f.getBa` so the | ||
| language server should return completions matching the prefix (e.g. | ||
| `getBaseName`). Uses `file_content` to provide inline query text, which | ||
| avoids disk I/O and produces a small, focused result set. | ||
|
|
||
| ## INPUTS | ||
|
|
||
| - **file_content**: Inline QL with cursor after `f.getBa` | ||
| - **file_path**: `server/ql/javascript/examples/src/ExampleQuery1/ExampleQuery1.ql` | ||
| - **line**: 3 (`where f.getBa`) | ||
| - **character**: 13 (end of `getBa` prefix) | ||
| - **workspace_uri**: `server/ql/javascript/examples` | ||
|
|
||
| ## EXPECTED OUTPUTS | ||
|
|
||
| - A list of completion items matching the `getBa` prefix (e.g. `getBaseName`). | ||
| - Monitoring state updated to record a successful `codeql_lsp_completion` call. |
14 changes: 14 additions & 0 deletions
14
...tests/primitives/tools/codeql_lsp_completion/basic_completion/after/monitoring-state.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| { | ||
| "sessions": [ | ||
| { | ||
| "id": "integration_test_session", | ||
| "calls": [ | ||
| { | ||
| "tool": "codeql_lsp_completion", | ||
| "timestamp": "2026-02-08T00:00:00.000Z", | ||
| "status": "success" | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } |
10 changes: 10 additions & 0 deletions
10
...ests/primitives/tools/codeql_lsp_completion/basic_completion/before/monitoring-state.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| { | ||
| "sessions": [], | ||
| "parameters": { | ||
| "file_content": "import javascript\n\nfrom File f\nwhere f.getBa\nselect f", | ||
| "file_path": "server/ql/javascript/examples/src/ExampleQuery1/ExampleQuery1.ql", | ||
| "line": 3, | ||
| "character": 13, | ||
| "workspace_uri": "server/ql/javascript/examples" | ||
| } | ||
| } |
21 changes: 21 additions & 0 deletions
21
...n-tests/primitives/tools/codeql_lsp_completion/from_clause_completion/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| # `codeql_lsp_completion/from_clause_completion` | ||
|
|
||
| ## PURPOSE | ||
|
|
||
| Tests that `codeql_lsp_completion` returns keyword completions when the cursor | ||
| is positioned after a partial keyword `wh` following a `from` clause. Uses | ||
| `file_content` to provide inline query text, producing a small set of | ||
| completions (e.g. `where`) rather than an exhaustive type list. | ||
|
|
||
| ## INPUTS | ||
|
|
||
| - **file_content**: Inline QL with cursor after `wh` prefix | ||
| - **file_path**: `server/ql/javascript/examples/src/ExampleQuery1/ExampleQuery1.ql` | ||
| - **line**: 3 (after `wh`) | ||
| - **character**: 2 (end of `wh` prefix) | ||
| - **workspace_uri**: `server/ql/javascript/examples` | ||
|
|
||
| ## EXPECTED OUTPUTS | ||
|
|
||
| - A list of completion items matching the `wh` prefix (e.g. `where`). | ||
| - Monitoring state updated to record a successful `codeql_lsp_completion` call. |
14 changes: 14 additions & 0 deletions
14
...primitives/tools/codeql_lsp_completion/from_clause_completion/after/monitoring-state.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| { | ||
| "sessions": [ | ||
| { | ||
| "id": "integration_test_session", | ||
| "calls": [ | ||
| { | ||
| "tool": "codeql_lsp_completion", | ||
| "timestamp": "2026-02-08T00:00:00.000Z", | ||
| "status": "success" | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } |
10 changes: 10 additions & 0 deletions
10
...rimitives/tools/codeql_lsp_completion/from_clause_completion/before/monitoring-state.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| { | ||
| "sessions": [], | ||
| "parameters": { | ||
| "file_content": "import javascript\n\nfrom File f\nwh", | ||
| "file_path": "server/ql/javascript/examples/src/ExampleQuery1/ExampleQuery1.ql", | ||
| "line": 3, | ||
| "character": 2, | ||
| "workspace_uri": "server/ql/javascript/examples" | ||
| } | ||
| } |
21 changes: 21 additions & 0 deletions
21
...gration-tests/primitives/tools/codeql_lsp_definition/basic_definition/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| # `codeql_lsp_definition/basic_definition` | ||
|
|
||
| ## PURPOSE | ||
|
|
||
| Tests that `codeql_lsp_definition` resolves the definition of a type used in a | ||
| `from` clause. The cursor is on `File` (line 2, character 7) which should | ||
| resolve to the `File` class definition in the JavaScript CodeQL library. | ||
| Uses `file_content` to provide inline query text. | ||
|
|
||
| ## INPUTS | ||
|
|
||
| - **file_content**: Inline QL with `from File f` clause | ||
| - **file_path**: `server/ql/javascript/examples/src/ExampleQuery1/ExampleQuery1.ql` | ||
| - **line**: 2 (on the `File` type in `from File f`) | ||
| - **character**: 7 (cursor on `File`) | ||
| - **workspace_uri**: `server/ql/javascript/examples` | ||
|
|
||
| ## EXPECTED OUTPUTS | ||
|
|
||
| - One or more definition locations with URIs pointing to `.qll` library files. | ||
| - Monitoring state updated to record a successful `codeql_lsp_definition` call. |
14 changes: 14 additions & 0 deletions
14
...tests/primitives/tools/codeql_lsp_definition/basic_definition/after/monitoring-state.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| { | ||
| "sessions": [ | ||
| { | ||
| "id": "integration_test_session", | ||
| "calls": [ | ||
| { | ||
| "tool": "codeql_lsp_definition", | ||
| "timestamp": "2026-02-08T00:00:00.000Z", | ||
| "status": "success" | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } |
10 changes: 10 additions & 0 deletions
10
...ests/primitives/tools/codeql_lsp_definition/basic_definition/before/monitoring-state.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| { | ||
| "sessions": [], | ||
| "parameters": { | ||
| "file_content": "import javascript\n\nfrom File f\nwhere f.getBaseName() = \"test.js\"\nselect f, \"found\"", | ||
| "file_path": "server/ql/javascript/examples/src/ExampleQuery1/ExampleQuery1.ql", | ||
| "line": 2, | ||
| "character": 7, | ||
| "workspace_uri": "server/ql/javascript/examples" | ||
| } | ||
| } |
21 changes: 21 additions & 0 deletions
21
...gration-tests/primitives/tools/codeql_lsp_definition/class_definition/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| # `codeql_lsp_definition/class_definition` | ||
|
|
||
| ## PURPOSE | ||
|
|
||
| Tests that `codeql_lsp_definition` resolves the definition of the `javascript` | ||
| library module from an `import` statement. The cursor is on `javascript` | ||
| (line 0, character 10) which should resolve to the library module definition. | ||
| Uses `file_content` to provide inline query text. | ||
|
|
||
| ## INPUTS | ||
|
|
||
| - **file_content**: Inline QL with `import javascript` statement | ||
| - **file_path**: `server/ql/javascript/examples/src/ExampleQuery1/ExampleQuery1.ql` | ||
| - **line**: 0 (on the `import javascript` statement) | ||
| - **character**: 10 (cursor on `javascript`) | ||
| - **workspace_uri**: `server/ql/javascript/examples` | ||
|
|
||
| ## EXPECTED OUTPUTS | ||
|
|
||
| - One or more definition locations with URIs pointing to `.qll` library files. | ||
| - Monitoring state updated to record a successful `codeql_lsp_definition` call. |
14 changes: 14 additions & 0 deletions
14
...tests/primitives/tools/codeql_lsp_definition/class_definition/after/monitoring-state.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| { | ||
| "sessions": [ | ||
| { | ||
| "id": "integration_test_session", | ||
| "calls": [ | ||
| { | ||
| "tool": "codeql_lsp_definition", | ||
| "timestamp": "2026-02-08T00:00:00.000Z", | ||
| "status": "success" | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } |
10 changes: 10 additions & 0 deletions
10
...ests/primitives/tools/codeql_lsp_definition/class_definition/before/monitoring-state.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| { | ||
| "sessions": [], | ||
| "parameters": { | ||
| "file_content": "import javascript\n\nfrom File f\nwhere f.getBaseName() = \"test.js\"\nselect f, \"found\"", | ||
| "file_path": "server/ql/javascript/examples/src/ExampleQuery1/ExampleQuery1.ql", | ||
| "line": 0, | ||
| "character": 10, | ||
| "workspace_uri": "server/ql/javascript/examples" | ||
| } | ||
| } |
17 changes: 17 additions & 0 deletions
17
...ion-tests/primitives/tools/codeql_lsp_diagnostics/semantic_validation/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| # `codeql_lsp_diagnostics/semantic_validation` | ||
|
|
||
| ## PURPOSE | ||
|
|
||
| Tests that `codeql_lsp_diagnostics` detects semantic errors in QL code that | ||
| references undefined types (e.g., `UndefinedType`). | ||
|
|
||
| ## INPUTS | ||
|
|
||
| - **ql_code**: A QL query fragment referencing `UndefinedType` which does not | ||
| exist, triggering a semantic "could not resolve type" diagnostic. | ||
|
|
||
| ## EXPECTED OUTPUTS | ||
|
|
||
| - `isValid` is `false` with semantic diagnostics about unresolvable types. | ||
| - The `before/semantic_query.ql` contains the erroneous query; `after/semantic_query.ql` shows the corrected version after addressing the diagnostics. | ||
| - Monitoring state updated to record a successful `codeql_lsp_diagnostics` call. | ||
17 changes: 17 additions & 0 deletions
17
...s/primitives/tools/codeql_lsp_diagnostics/semantic_validation/after/monitoring-state.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| { | ||
| "sessions": [ | ||
| { | ||
| "id": "integration_test_session", | ||
| "calls": [ | ||
| { | ||
| "tool": "codeql_lsp_diagnostics", | ||
| "timestamp": "2026-02-08T00:00:00.000Z", | ||
| "status": "success", | ||
| "parameters": { | ||
| "ql_code": "from NonExistentType item\nwhere item.someProperty() = \"value\"\nselect item, \"This has semantic errors\"" | ||
| } | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } |
File renamed without changes.
6 changes: 6 additions & 0 deletions
6
.../primitives/tools/codeql_lsp_diagnostics/semantic_validation/before/monitoring-state.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| { | ||
| "sessions": [], | ||
| "parameters": { | ||
| "ql_code": "from UndefinedType x\nwhere x = \"test\"\nselect x, \"semantic error: undefined type\"" | ||
| } | ||
| } |
File renamed without changes.
15 changes: 15 additions & 0 deletions
15
...ation-tests/primitives/tools/codeql_lsp_diagnostics/syntax_validation/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| # `codeql_lsp_diagnostics/syntax_validation` | ||
|
|
||
| ## PURPOSE | ||
|
|
||
| Tests that `codeql_lsp_diagnostics` detects syntax errors in invalid QL code. | ||
|
|
||
| ## INPUTS | ||
|
|
||
| - **ql_code**: Invalid QL snippet with syntax errors (`invalid_type x\nwhere x = "test"\nselect x, "This has syntax errors"`). | ||
|
|
||
| ## EXPECTED OUTPUTS | ||
|
|
||
| - `isValid` is `false` with one or more error diagnostics. | ||
| - The `before/test_query.ql` contains the erroneous query; `after/test_query.ql` shows the corrected version after addressing the diagnostics. | ||
| - Monitoring state updated to record a successful `codeql_lsp_diagnostics` call. |
14 changes: 14 additions & 0 deletions
14
...sts/primitives/tools/codeql_lsp_diagnostics/syntax_validation/after/monitoring-state.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| { | ||
| "sessions": [ | ||
| { | ||
| "id": "integration_test_session", | ||
| "calls": [ | ||
| { | ||
| "tool": "codeql_lsp_diagnostics", | ||
| "timestamp": "2026-02-08T00:00:00.000Z", | ||
| "status": "success" | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } |
File renamed without changes.
6 changes: 6 additions & 0 deletions
6
...ts/primitives/tools/codeql_lsp_diagnostics/syntax_validation/before/monitoring-state.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| { | ||
| "sessions": [], | ||
| "parameters": { | ||
| "ql_code": "invalid_type x\nwhere x = \"test\"\nselect x, \"This has syntax errors\"" | ||
| } | ||
| } |
File renamed without changes.
16 changes: 16 additions & 0 deletions
16
...n-tests/primitives/tools/codeql_lsp_diagnostics/valid_query_no_errors/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| # `codeql_lsp_diagnostics/valid_query_no_errors` | ||
|
|
||
| ## PURPOSE | ||
|
|
||
| Tests that `codeql_lsp_diagnostics` returns zero diagnostics for a | ||
| syntactically and semantically valid QL snippet. | ||
|
|
||
| ## INPUTS | ||
|
|
||
| - **ql_code**: A valid inline QL query (`select 1 + 1`). | ||
|
|
||
| ## EXPECTED OUTPUTS | ||
|
|
||
| - `isValid` is `true`, zero errors/warnings in the summary. | ||
| - The `valid_query.ql` file remains unchanged. | ||
| - Monitoring state updated to record a successful `codeql_lsp_diagnostics` call. |
14 changes: 14 additions & 0 deletions
14
...primitives/tools/codeql_lsp_diagnostics/valid_query_no_errors/after/monitoring-state.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| { | ||
| "sessions": [ | ||
| { | ||
| "id": "integration_test_session", | ||
| "calls": [ | ||
| { | ||
| "tool": "codeql_lsp_diagnostics", | ||
| "timestamp": "2026-02-08T00:00:00.000Z", | ||
| "status": "success" | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } |
11 changes: 11 additions & 0 deletions
11
...-tests/primitives/tools/codeql_lsp_diagnostics/valid_query_no_errors/after/valid_query.ql
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| /** | ||
| * @name Valid Test Query | ||
| * @description A valid CodeQL query with no syntax errors | ||
| * @id test/valid-query | ||
| * @kind problem | ||
| * @problem.severity warning | ||
| */ | ||
|
|
||
| from string x | ||
| where x = "test" | ||
| select x, "This is a valid query" |
6 changes: 6 additions & 0 deletions
6
...rimitives/tools/codeql_lsp_diagnostics/valid_query_no_errors/before/monitoring-state.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| { | ||
| "sessions": [], | ||
| "parameters": { | ||
| "ql_code": "select 1 + 1" | ||
| } | ||
| } |
11 changes: 11 additions & 0 deletions
11
...tests/primitives/tools/codeql_lsp_diagnostics/valid_query_no_errors/before/valid_query.ql
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| /** | ||
| * @name Valid Test Query | ||
| * @description A valid CodeQL query with no syntax errors | ||
| * @id test/valid-query | ||
| * @kind problem | ||
| * @problem.severity warning | ||
| */ | ||
|
|
||
| from string x | ||
| where x = "test" | ||
| select x, "This is a valid query" |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.