feat: Add multiple CodeQL locations#4
Merged
Merged
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds flexible handling for the CodeQL working directory by introducing a helper to locate or create it, and updates main.rs to use this helper.
- Introduce
Action::get_codeql_dirto pick/create a CodeQL base directory in either.codeqlor the runner temp area. - Update
main.rsto callget_codeql_dirand derivedatabasesandsarif_outputpaths from it.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/action.rs | Added get_codeql_dir to locate or create the CodeQL directory |
| src/main.rs | Replaced hard-coded .codeql joins with calls to get_codeql_dir |
Comments suppressed due to low confidence (2)
src/action.rs:139
- No tests cover
get_codeql_dir; consider adding unit tests for both the primary.codeqlpath and the fallback temp path, including failure scenarios.
pub fn get_codeql_dir(&self) -> Result<PathBuf> {
src/main.rs:28
- [nitpick] The variable name
databasesholds a directory path. Consider renaming it todatabases_dirto clarify its purpose.
let databases = codeql_dir.join("databases");
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.