chore(security): cooldown, deterministic installs, harden labeler workflow#262
Open
Copilot wants to merge 4 commits into
Open
chore(security): cooldown, deterministic installs, harden labeler workflow#262Copilot wants to merge 4 commits into
Copilot wants to merge 4 commits into
Conversation
…kflow - dependabot.yml: add cooldown (default-days: 3) to all entries; replace github-actions groups with single actions:patterns:['*'] group - build.yml: replace npm install -g markdownlint-cli with npm ci + npx markdownlint; add root package.json + package-lock.json - requirements.txt: hash-pinned (uv pip compile --generate-hashes) for ghastoolkit + yq - coverage.yml, publish.yml, release.yml, version.yml: pip install -r requirements.txt --require-hashes - labeler.yml: remove actions/checkout step (actions/labeler@v6 does not need it) Co-authored-by: felickz <1760475+felickz@users.noreply.github.com>
Co-authored-by: felickz <1760475+felickz@users.noreply.github.com>
Co-authored-by: felickz <1760475+felickz@users.noreply.github.com>
Co-authored-by: felickz <1760475+felickz@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
felickz
May 20, 2026 21:13
View session
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens the repository’s supply-chain posture by making dependency installs more deterministic across CI workflows and reducing exposure in the pull_request_target labeler workflow.
Changes:
- Added hash-locked Python dependencies (
requirements.in→ generatedrequirements.txt) and updated workflows to install with--require-hashes. - Introduced deterministic Markdown linting in CI via
npm ci+npx markdownlintwith a committed lockfile. - Updated Dependabot configuration with a cooldown and simplified grouping for GitHub Actions; removed an unnecessary checkout step from the labeler workflow.
Show a summary per file
| File | Description |
|---|---|
| requirements.in | Declares direct Python dependencies to compile from. |
| requirements.txt | Adds a hash-pinned, fully resolved Python dependency set for reproducible installs. |
| package.json | Adds Node devDependency for markdownlint-cli used in CI. |
| package-lock.json | Locks Node dependency tree and integrity hashes for deterministic npm ci. |
| .gitignore | Ignores node_modules/ after introducing Node tooling. |
| .github/workflows/build.yml | Switches Markdown lint step to npm ci + npx markdownlint. |
| .github/workflows/coverage.yml | Uses hash-locked Python requirements for CI scripting. |
| .github/workflows/publish.yml | Uses hash-locked Python requirements for release checks. |
| .github/workflows/release.yml | Uses hash-locked Python requirements for version extraction. |
| .github/workflows/version.yml | Uses hash-locked Python requirements for version bump tooling. |
| .github/workflows/labeler.yml | Removes checkout step from pull_request_target labeler job. |
| .github/dependabot.yml | Adds cooldown and updates grouping strategy for GitHub Actions. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 9/12 changed files
- Comments generated: 3
Comment on lines
+5
to
+10
| "scripts": { | ||
| "test": "echo \"Error: no test specified\" && exit 1" | ||
| }, | ||
| "keywords": [], | ||
| "author": "", | ||
| "license": "ISC", |
| "version": "1.0.0", | ||
| "description": "markdownlint tooling for CI", | ||
| "scripts": { | ||
| "test": "echo \"Error: no test specified\" && exit 1" |
| "author": "", | ||
| "license": "ISC", | ||
| "devDependencies": { | ||
| "markdownlint-cli": "^0.48.0" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses SCA audit findings: adds Dependabot cooldown, pins all dependency installs to hashes, and removes an unnecessary checkout from the labeler workflow.
Dependabot (
dependabot.yml)cooldown: default-days: 3to all ecosystem entriesgithub-actions: replaced production/development groups with singleactions: patterns: ["*"]cargo: existing groups left intact, cooldown onlyDeterministic npm (
build.yml+ newpackage.json,package-lock.json)markdownlint-climoved from ad-hoc global install to pinned devDependencynpm install -g markdownlint-cli→npm ci && npx markdownlintHash-pinned Python (
requirements.in,requirements.txt)requirements.indeclares direct deps (ghastoolkit,yq)requirements.txtgenerated viauv pip compile --generate-hashes— all 13 transitive deps hash-lockedcoverage,publish,release,version) updated:Labeler hardening (
labeler.yml)actions/checkoutstep —actions/labeler@v6doesn't need it, and its presence unnecessarily expands the attack surface on apull_request_targettrigger