Create mermaid flowchart in new extractors/README.md#168
Closed
data-douser wants to merge 4 commits intoadvanced-security:mainfrom
Closed
Create mermaid flowchart in new extractors/README.md#168data-douser wants to merge 4 commits intoadvanced-security:mainfrom
extractors/README.md#168data-douser wants to merge 4 commits intoadvanced-security:mainfrom
Conversation
Adds a mermaid (markdown-formatted) flowchart to show the flow of execution for the current (shell-script-based) extractor implementation. Updates the root `.gitignore` file for this project and adds: - `extractors/.gitignore` - 'javascript/frameworks/cap/test/.gitignore'
lcartey
suggested changes
Jan 23, 2025
Contributor
lcartey
left a comment
lcartey
left a comment
There was a problem hiding this comment.
A couple of comments, but I think it's great to have this.
We should also note that this flowchart is for calling pre-finalize.sh manually. If you integrate the script into your CodeQL distribution, there will be a slightly different flow.
| SPF ==> |run the cds extractor| DIDX | ||
| JSE -.-> |extract javascript files:<br>_.html, .js, .json, .ts_| DB | ||
| DTRAC ==> |run the build --command| SPF | ||
| JSE ==> |run autobuild within<br>the javascript extractor| DTRAC |
Contributor
There was a problem hiding this comment.
I think the autobuilder extracts the JavaScript files. The pre-finalize.sh is not run by the autobuilder, so I think this node is in the wrong place.
data-douser
added a commit
to data-douser/codeql-sap-js
that referenced
this pull request
May 1, 2025
Adds the `extractors/README.md` file as an evolution of, and a replace ment for, PR advanced-security#168 from this `advanced-security/codeql-sap-js` repository. Updates the CDS tools documentation to reflect progress in the multi-stage process of rewriting the CDS extractor to be more maintainable (WIP) and performant (TODO).
Collaborator
Author
|
Closing this PR in favor of PR #188 . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a mermaid (markdown-formatted) flowchart to visually document the flow of execution for the current (shell-script-based) extractor implementation.
Also, updates the root
.gitignorefile for this project and adds new files at:extractors/.gitignorejavascript/frameworks/cap/test/.gitignore