Remove diagnostic query ListXssPartialPaths#232
Merged
data-douser merged 2 commits intomainfrom Sep 19, 2025
Merged
Conversation
Collaborator
|
@jeongsoolee09 Regarding your second objection (from PR description), does removing this diagnostics query in any way leave a new (or increased) gap in our testing of the models-as-data |
data-douser
approved these changes
Sep 19, 2025
Collaborator
data-douser
left a comment
There was a problem hiding this comment.
Pending resolution of one comment / question. Other than that, LGTM!
Contributor
Author
|
@data-douser No, it's closer to a supposed scenario where |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What This PR Contributes
This PR removes the diagnostic query
ListXssPartialPaths. This decision is made based on the following objections:summaryModelpredicate needs to be tested, this query can be trimmed down to target the predicate directly (or in a more reader-friendly way, usingModelsAsData::SummarizedCallableFromModel.getACall/0orsummaryStep/summaryStepNodesfrom the same module).Future Works
N/A