Skip to content

Add ordering assertion in cds-indexer test#379

Draft
Copilot wants to merge 3 commits into
mainfrom
copilot/patch-fix-code-review-suggestion
Draft

Add ordering assertion in cds-indexer test#379
Copilot wants to merge 3 commits into
mainfrom
copilot/patch-fix-code-review-suggestion

Conversation

Copilot AI commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

What This PR Contributes

  • Adds an explicit ordering assertion to the should install full project dependencies after successful cds-indexer run test in extractors/cds/tools/test/src/cds/indexer.test.ts.
    • Uses Jest's mock.invocationCallOrder to verify the cds-indexer spawnSync is invoked before projectInstallDependencies, guarding against regressions in orchestrateCdsIndexer's sequencing (full deps are only installed after a successful indexer run).
  • Removes a stray .codeql-version file accidentally tracked, keeping the change test-only.

Future Works

  • The remaining open review comment (r3381736303) on projectInstaller.ts regarding --ignore-scripts / opt-in script execution is out of scope here.

Copilot AI and others added 2 commits June 10, 2026 14:31
…test

Co-authored-by: data-douser <70299490+data-douser@users.noreply.github.com>
Co-authored-by: data-douser <70299490+data-douser@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix code based on review comment Add ordering assertion in cds-indexer test Jun 10, 2026
Copilot AI requested a review from data-douser June 10, 2026 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants