Skip to content

Add ordering assertion in cds-indexer test #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 3 commits into from
+8 −0
Closed

Add ordering assertion in cds-indexer test #379

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0918821
Initial plan
Copilot Jun 10, 2026
6da30d4
Add ordering assertion between cds-indexer and dependency install in …
Copilot Jun 10, 2026
30cc2e4
Remove unrelated .codeql-version file from PR
Copilot Jun 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions extractors/cds/tools/test/src/cds/indexer.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -514,6 +514,14 @@
orchestrateCdsIndexer(graph, '/source', new Map());

expect(projectInstaller.projectInstallDependencies).toHaveBeenCalledWith(project, '/source');

// The cds-indexer must run before the full dependency installation, so
// that dependencies are only installed after a successful indexer run.
const indexerSpawnOrder = (childProcess.spawnSync as jest.Mock).mock

Check failure on line 520 in extractors/cds/tools/test/src/cds/indexer.test.ts

View workflow job for this annotation

GitHub Actions / CDS extractor bundle validation 

Delete `⏎········`
.invocationCallOrder[0];
const installOrder = (projectInstaller.projectInstallDependencies as jest.Mock).mock
.invocationCallOrder[0];
expect(indexerSpawnOrder).toBeLessThan(installOrder);
});

it('should not install full project dependencies when cds-indexer fails', () => {
Expand Down
Loading