DataInterpolations v8.0.1 compat#60
Merged
Merged
Conversation
A change in DataInterpolations v8.0.1 enforces the ordering of the independent variable, has to be monotonically increasing. Apparently, in one test, SLAB returned a backwards timestep. I'm not sure how this is possible, but for safety ensure that the x and t correlations are sorted to be in ascending order.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #60 +/- ##
=======================================
Coverage 95.57% 95.58%
=======================================
Files 41 41
Lines 2692 2694 +2
=======================================
+ Hits 2573 2575 +2
Misses 119 119 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Owner
Author
|
To be clear: I checked this against the results of the original Fortran version of SLAB and it does actually go backwards in the transition between the steady state integration and the transient. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A change in DataInterpolations v8.0.1 enforces the ordering of the independent variable, it has to be monotonically increasing. Apparently, in one test, SLAB returned a backwards timestep. I'm not sure how this is possible, but for safety it now ensures that the x and t correlations are sorted to be in ascending order.