Palazzi short duration releases#67
Merged
Merged
Conversation
Just moving the approximation used in IntPuff to its own file and calling it "Palazzi". This is step 1. Step 2 is adding all the other features Palazzi may require and changing the default behaviour.
Palazzi is generic in regards to the plume model, it is simply $\Chi$ in the equation
Quick unit tests to ensure coverage.
Palazzi can be calculated differently depending on how $\sigma_x$ is calculated, and references disagree on how this should be done. Added a keyword argument to select the different options. Palazzi uses plume dispersion parameters by default, using $\sigma_x = \sigma_y$
Documentation of the Palazzi short duration model
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #67 +/- ##
==========================================
+ Coverage 95.85% 95.87% +0.01%
==========================================
Files 42 43 +1
Lines 2700 2712 +12
==========================================
+ Hits 2588 2600 +12
Misses 112 112 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Palazzi short duration model is an approximation to the integral over a series of Gaussian puffs. This model is used in the TNO Yellow Book and in the ALOHA tool and extends the existing IntPuff model.