Gaussian mixing layer#68
Merged
Merged
Conversation
Mixing layer model from ISC3 user guide, volume 2 equation 1-50. Calculates the full sum, without any checking to see if it is worth continuing.
SimpleAtmospheres have a default mixing height calculation, which is unfortunately a function of latitude. I used the default baked into TSCREEN and ISC3 (40\deg N) but this is problematic.
Updated the docs to refer to the Gaussian Mixing Layer model
Added mixing layer model based on an infinite sum of cosines. This converges very slowly (in my testing) but is used in some places.
Closed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #68 +/- ##
==========================================
+ Coverage 95.87% 96.03% +0.16%
==========================================
Files 43 46 +3
Lines 2712 2823 +111
==========================================
+ Hits 2600 2711 +111
Misses 112 112 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Owner
Author
|
Two mistakes:
|
Added a `ProblemDomain` type and a domain check function the generalize the GaussianPlumeSolution. Previously it was ignoring the mixing layer when deciding on the domain of the problem. Added a limiter to plume rise, forcing plume rise below the mixing layer.
Updated doc tests and unit tests to ensure better coverage, fix broken things.
Added checks to ensure simple mixing layer exits the for loop correctly, either by breaking out early if the sum has converged or by running out the loop
Owner
Author
|
Updates followed the philosophy that this should be an extension of the existing The two algorithms are checked for correctness, basically, by seeing if they get the same answer. Which they should if enough terms are included in the sums. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gaussian plumes released beneath an inversion become trapped, leading to larger ground-level concentrations.