Skip to content

Commit 8950ef6

Browse files
committed
Migrate java-ffmpeg to jdk21 base
1 parent 3999e73 commit 8950ef6

9 files changed

Lines changed: 23 additions & 24 deletions

File tree

.github/workflows/build.yml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@ jobs:
4242
password: ${{ secrets.GITHUB_TOKEN }}
4343

4444
- name: Build and export to Docker
45+
id: docker_build
4546
uses: docker/build-push-action@v2
4647
with:
4748
context: .
@@ -52,9 +53,9 @@ jobs:
5253
ghcr.io/${{ github.repository_owner }}/${{ env.IMAGE }}:${{ env.GIT_BRANCH }}
5354
5455
55-
# - name: test docker image
56-
# run: |
57-
# cd test && bash ./run_tests.sh "$IMAGE:$GIT_BRANCH"
56+
- name: test docker image
57+
run: |
58+
cd test && bash ./run_tests.sh "ghcr.io/$GITHUB_REPOSITORY_OWNER/$IMAGE:$GIT_BRANCH"
5859
5960
- name: Run docker image analysis
6061
continue-on-error: true

Dockerfile

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM aemdesign/oracle-jdk:jdk17 as base
1+
FROM aemdesign/oracle-jdk:jdk21 as base
22

33
RUN apt-get update -y && \
44
apt-get install libgomp1 libxdmcp6 libexpat-dev -y && \
@@ -419,6 +419,7 @@ RUN \
419419
DIR=$(mktemp -d) && cd ${DIR} && \
420420
curl -sLO https://xorg.freedesktop.org/archive/individual/proto/xcb-proto-${XCBPROTO_VERSION}.tar.gz && \
421421
tar -zx --strip-components=1 -f xcb-proto-${XCBPROTO_VERSION}.tar.gz && \
422+
find . -exec touch -d "@$(date +%s)" {} + && \
422423
ACLOCAL_PATH="${PREFIX}/share/aclocal" ./autogen.sh && \
423424
./configure --prefix="${PREFIX}" && \
424425
make && \
@@ -729,14 +730,14 @@ RUN \
729730
FROM base
730731

731732
LABEL os="debian 8" \
732-
java="1.8" \
733+
java="21" \
733734
container.description="java and ffmpeg" \
734735
image.source="https://github.com/jrottenberg/ffmpeg/tree/master/docker-images" \
735736
version="1.0.0" \
736737
maintainer="devops <devops@aem.design>" \
737738
imagename="java-ffmpeg" \
738-
test.command=" java -version 2>&1 | grep 'java version' | sed -e 's/.*java version "\(.*\)".*/\1/'" \
739-
test.command.verify="1.8"
739+
test.command="java --version" \
740+
test.command.verify="21."
740741

741742
ENV LD_LIBRARY_PATH=/usr/local/lib64:/usr/local/lib
742743

Dockerfile-debug

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM aemdesign/oracle-jdk:jdk11 as base
1+
FROM aemdesign/oracle-jdk:jdk21 as base
22

33
RUN dnf -y install libgomp && \
44
dnf clean all;
@@ -585,8 +585,8 @@ LABEL os="debian" \
585585
version="1.0.0" \
586586
maintainer="devops <devops@aem.design>" \
587587
imagename="java-ffmpeg" \
588-
test.command=" java -version 2>&1 | grep 'java version' | sed -e 's/.*java version "\(.*\)".*/\1/'" \
589-
test.command.verify="11."
588+
test.command="java --version" \
589+
test.command.verify="21."
590590

591591
ENV LD_LIBRARY_PATH=/usr/local/lib64:/usr/local/lib
592592

Dockerfile-serial

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM aemdesign/oracle-jdk:jdk11 as base
1+
FROM aemdesign/oracle-jdk:jdk21 as base
22

33
RUN apt-get update -y && \
44
apt-get install libgomp1 -y && \
@@ -634,13 +634,13 @@ FROM base
634634
ENV LD_LIBRARY_PATH=${LD_LIBRARY_PATH}
635635

636636
LABEL os="debian 8" \
637-
java="1.8" \
637+
java="21" \
638638
container.description="java and ffmpeg" \
639639
image.source="https://github.com/jrottenberg/ffmpeg/tree/master/docker-images" \
640640
version="1.0.0" \
641641
maintainer="devops <devops@aem.design>" \
642642
imagename="java-ffmpeg" \
643-
test.command=" java -version 2>&1 | grep 'java version' | sed -e 's/.*java version "\(.*\)".*/\1/'" \
644-
test.command.verify="1.8"
643+
test.command="java --version" \
644+
test.command.verify="21."
645645

646646
COPY --from=build /usr/local/ /usr/local/

README.md

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
## Java with FFMPEG
22

3-
[![build](https://github.com/aem-design/docker-java-ffmpeg/actions/workflows/build.yml/badge.svg?branch=jdk17)](https://github.com/aem-design/docker-java-ffmpeg/actions/workflows/build.yml)
3+
[![build](https://github.com/aem-design/docker-java-ffmpeg/actions/workflows/build.yml/badge.svg?branch=jdk21)](https://github.com/aem-design/docker-java-ffmpeg/actions/workflows/build.yml)
44
[![github license](https://img.shields.io/github/license/aem-design/java-ffmpeg)](https://github.com/aem-design/java-ffmpeg)
55
[![github issues](https://img.shields.io/github/issues/aem-design/java-ffmpeg)](https://github.com/aem-design/java-ffmpeg)
66
[![github last commit](https://img.shields.io/github/last-commit/aem-design/java-ffmpeg)](https://github.com/aem-design/java-ffmpeg)
@@ -22,7 +22,7 @@ Images are available on both registries:
2222
### Tags
2323

2424
- `latest` - Latest build from main branch
25-
- `jdk17` - JDK 17 branch
25+
- `jdk21` - JDK 21 branch
2626
- Version tags (pushed when git tags are created)
2727

2828
### Included Packages
@@ -125,4 +125,3 @@ This will automatically build and push versioned Docker images to both registrie
125125
## License
126126

127127
See [LICENSE](LICENSE) file for details.
128-

build.ps1

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ Param(
22
[string]$LOG_PATH = "${PWD}\logs",
33
[string]$LOG_PEFIX = "docker",
44
[string]$LOG_SUFFIX = ".log",
5-
[string]$TAG = "jdk11",
5+
[string]$TAG = "jdk21",
66
[string]$FILE = "Dockerfile",
77
[string]$FUNCTIONS_URI = "https://github.com/aem-design/aemdesign-docker/releases/latest/download/functions.ps1",
88
[string]$COMMAND = "docker buildx build . -f .\${FILE} -t ${TAG}"
@@ -19,4 +19,3 @@ printSectionLine "$COMMAND" "warn"
1919
Invoke-Expression -Command "$COMMAND" | Tee-Object -Append -FilePath "${LOG_FILE}"
2020

2121

22-

debug.ps1

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ Param(
22
[string]$LOG_PATH = "${PWD}\logs",
33
[string]$LOG_PEFIX = "docker",
44
[string]$LOG_SUFFIX = ".log",
5-
[string]$TAG = "jdk11",
5+
[string]$TAG = "jdk21",
66
[string]$FILE = "Dockerfile",
77
[string]$FUNCTIONS_URI = "https://github.com/aem-design/aemdesign-docker/releases/latest/download/functions.ps1",
88
[string]$COMMAND = "docker buildx build . -f .\${FILE} -t ${TAG}"

docker-compose.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,6 @@ aem-base:
55
ffmpeg.version: "2.8.3"
66
ffmpeg.plugins: "yasm x264 x265 libogg libopus libvorbis libtheora libvpx libmp3lame faac xvid fdk-aac ffmpeg"
77
os.version: "debian"
8-
java.version: "oracle 8"
8+
java.version: "oracle 21"
99
container.description: "aem instance, will run as author unless specified otherwise"
1010
container_name: "java-ffmpeg"

test/run_tests.sh

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
# IMAGE_NAME specifies a name of the candidate image used for testing.
77
# The image has to be available before this script is executed.
88
#
9-
IMAGE_NAME=${1:-aemdesign/java-ffmpeg:jdk11}
9+
IMAGE_NAME=${1:-aemdesign/java-ffmpeg:jdk21}
1010
FLAG_DEBUG=${2:-true}
1111
IP=$(which ip)
1212
if [[ -z $IP ]]; then
@@ -95,7 +95,7 @@ printDebug() {
9595

9696
test_usage_java() {
9797
printLine "Testing java"
98-
CHECK="11"
98+
CHECK="$(cat ../Dockerfile | grep -m1 test.command.verify | sed -e 's/.*test.command.verify=\"\(.*\)\".*/\1/g')"
9999

100100
printLine "Starting Container"
101101

@@ -130,4 +130,3 @@ test_usage_ffmpeg() {
130130
test_usage_java
131131

132132
test_usage_ffmpeg
133-

0 commit comments

Comments
 (0)