Fix site JSON-LD schema and canonical cascade resolution#216
Merged
Conversation
The button_group fieldtype augments to a LabeledValue, so strict comparisons (===, match) in siteSchema() and canonical() always fell through to their default branches: site JSON-LD never rendered (#214) and a custom or entry canonical was silently replaced with the page's own URL. Call ?->value() at the comparison sites, mirroring pageSchema.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the site JSON-LD schema and the canonical URL being silently ignored. The
button_groupfieldtype augments to aLabeledValue, so the strict comparisons insiteSchema()andcanonical()always fell through to their defaults. Calling?->value()at the comparison sites unwraps the underlying string, matching the existing pattern inpageSchema(). Closes #214.