Fix invalid breadcrumb JSON-LD#217
Merged
Merged
Conversation
spatie/schema-org's serializeProperty() only recurses into PHP arrays, so the Laravel Collection passed to itemListElement() got coerced via __toString() into a JSON string. That left BreadcrumbList with a stringified itemListElement and per-item @context, which Search Console flagged as invalid (#215). Calling ->all() lets serializeProperty recurse normally and strip the nested @context.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the breadcrumb JSON-LD coming out invalid. Closes #215.