Fix eloquent user type error#218
Merged
Merged
Conversation
When the eloquent users repository is used, Laravel's Gate dispatches the host app's Authenticatable model (e.g. App\Models\User), which doesn't implement Statamic\Contracts\Auth\User. UserFacade::fromUser() already converts any Authenticatable into the contract before checks, so the type hints just blocked non-super users from the SEO pages. Fixes #108.
aerni
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the
Statamic\Contracts\Auth\Usertype hint fromSeoContentGate::editContent()and theSeoSetPolicymethods that Laravel's Gate calls. With the eloquent users repository, Laravel passes the host app'sAuthenticatablemodel, which doesn't implement the contract.UserFacade::fromUser()already handles the conversion, so the hint was the only thing blocking non-super users from SEO pages.This is the v3 regression of the original v2 fix in #110.
Fixes #108.