fix sass warnings#38
Merged
Merged
Conversation
Collaborator
stevecheckoway
commented
Apr 15, 2026
stevecheckoway
commented
- Fix @import deprecation warnings
- Move assets/css/style.scss to assets/main.scss
- Replace deprecated functions
Sass will no longer support @import (the equivalent of C's #include). Instead, there's a new module system that uses @use and @forward. I'm following the changes made in this PR. jekyll/minima#848
Jekyll seems to be looking for `assets/main.scss` and if it doesn't exist, it's substituting `@import "minima"` which is causing another deprecation warning.
darken() and lighten() are global functions and as such are deprecated. Replace them with `color.adjust()` which can change the lightness in the same manner. I'm following this PR. jekyll/minima#849
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.