Run doctest in CI and fix errors in the documentation examples#1193
Run doctest in CI and fix errors in the documentation examples#1193LegrandNico wants to merge 3 commits intoaesara-devs:mainfrom
Conversation
Fix doctest errors
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1193 +/- ##
========================================
Coverage 79.13% 79.13%
========================================
Files 173 173
Lines 48492 48492
Branches 10966 10309 -657
========================================
Hits 38374 38374
Misses 7625 7625
Partials 2493 2493
|
| {~_2: <aesara.scalar.basic.Add at 0x7f54dfa5a350>, ~_3: e(x, y)} | ||
| {~_2: <aesara.scalar.basic.Add object at 0x7fc277b841c0>, ~_3: ExpressionTuple((x, y))} | ||
| >>> s = unify(cons(op_lv, args_lv), add(x, y, z)) | ||
| >>> s | ||
| {~_2: <aesara.scalar.basic.Add at 0x7f54dfa5a350>, ~_3: e(x, y, z)} | ||
| {~_2: <aesara.scalar.basic.Add object at 0x7fc277b841c0>, ~_3: ExpressionTuple((x, y, z))} |
There was a problem hiding this comment.
Looks like we need to take another approach altogether here (e.g. one that doesn't print local locations/addresses).
| branches: | ||
| - main | ||
| - checks | ||
| pull_request: | ||
| branches: | ||
| - main |
There was a problem hiding this comment.
Are these settings preventing the workflow from running in this PR?
|
Is there anything outstanding here @LegrandNico, besides the conflicts? |
|
I can work on it a bit later today. I had difficulties creating a new action and I was not sure if this should be a part of the |
Great! I think a |
brandonwillard
left a comment
There was a problem hiding this comment.
Looks like there are quite a few merge fixes needed now.
This PR will contribute to #1191 by:
The remaining errors are less trivial than formatting issues and will probably require more careful editing.
I also have trouble fixing errors where the structure of a graph is returned, pasting the actual output is not enough here, this is probably due to whitespace formatting (see the
NORMALIZE_WHITESPACEoption from doctest?).