feat: add Dividends column to holdings table#692
Open
kwaich wants to merge 2 commits into
Open
Conversation
Add an optional Dividends column to the holdings table that shows total income per holding sourced from the income summary (TOTAL period). Column is hidden by default and togglable via the column visibility menu.
Contributor
Author
|
hi @afadil , just checking in on this PR. Let me know if you need any adjustments or further information! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a Dividends column to the holdings table showing total lifetime income earned per holding. The column is hidden by default and can be enabled via the column visibility toggle (consistent with Asset Type and Book Cost columns).
Implementation details:
getIncomeSummaryquery (INCOME_SUMMARYquery key) — no new backend changesIncomeSummary.byAsset(TOTAL period)Checklist
Contributor License Agreement.
By submitting this PR, I agree to the
CLA.