Track owner approval packet in release dashboard#2002
Merged
Conversation
Contributor
|
ECC bundle files are already tracked in this repository. Skipping generation of another bundle PR. |
Contributor
📝 WalkthroughWalkthroughThis PR refreshes release evidence and automation tooling for the May 19, 2026 rc.1 snapshot. It introduces ChangesRelease Evidence & Owner-Approval-Packet Gate
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (2)
scripts/operator-readiness-dashboard.js (1)
591-592: ⚡ Quick winExtract the owner-approval packet artifact path to a constant.
The same date-stamped path is now duplicated across requirement wiring and artifact metadata. Pull it into a single constant to avoid snapshot drift bugs on the next evidence refresh.
♻️ Proposed refactor
+const OWNER_APPROVAL_PACKET_ARTIFACT = 'docs/releases/2.0.0-rc.1/owner-approval-packet-2026-05-19.md'; +const OWNER_APPROVAL_PACKET_BASENAME = 'owner-approval-packet-2026-05-19.md'; ... - const ownerApprovalPacket = readText(rootDir, 'docs/releases/2.0.0-rc.1/owner-approval-packet-2026-05-19.md'); + const ownerApprovalPacket = readText(rootDir, OWNER_APPROVAL_PACKET_ARTIFACT); ... - ]) && includesAll(previewManifest, ['owner-approval-packet-2026-05-19.md']); + ]) && includesAll(previewManifest, [OWNER_APPROVAL_PACKET_BASENAME]); ... - 'docs/releases/2.0.0-rc.1/owner-approval-packet-2026-05-19.md', + OWNER_APPROVAL_PACKET_ARTIFACT,As per coding guidelines, "Do not use hardcoded values; use constants or configuration instead".
Also applies to: 810-814
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@scripts/operator-readiness-dashboard.js` around lines 591 - 592, Extract the duplicated date-stamped artifact path into a single constant (e.g., OWNER_APPROVAL_PACKET_PATH) and replace the inline literals used to read the file (currently used when initializing ownerApprovalPacket via readText and any other occurrences such as where previewManifest/metadata reference the same path) so both the requirement wiring and artifact metadata use that constant; update all other duplicate occurrences mentioned (around the ownerApprovalPacket and the block referenced by the reviewer, including the section around previewManifest and the region noted as also applying to 810-814) to reference the new constant instead of hardcoded strings.tests/docs/ecc2-release-surface.test.js (1)
253-269: 💤 Low valueConsider extracting evidence markers to constants.
The new test correctly validates that the GA roadmap reflects the current May 19 evidence. However, the test contains multiple hardcoded string literals for evidence markers, which violates the coding guideline: "Do not use hardcoded values; use constants or configuration instead."
While these hardcoded values are intentional test data (meant to fail when evidence is refreshed), extracting them to constants at the test scope would improve readability and make the test's intent clearer. As per coding guidelines, avoid hardcoded values in source code.
♻️ Optional refactor to extract markers
test('GA roadmap mirrors the current May 19 release evidence', () => { const roadmap = read('docs/ECC-2.0-GA-ROADMAP.md'); + + // May 19 evidence markers that must be present + const requiredMarkers = [ + 'owner-approval-packet-2026-05-19.md', + 'preview-pack smoke digest `790430aef4a8`', + 'local 2550-test suite', + 'PR `#2001`', + 'GitHub Actions run `26102500291`', + 'owner approval packet', + ]; + + // Stale markers that must not be present + const excludedMarkers = [ + 'preview-pack smoke digest `bc2bf157616e`', + 'local 2544-test suite', + ]; - for (const marker of [ - 'owner-approval-packet-2026-05-19.md', - 'preview-pack smoke digest `790430aef4a8`', - 'local 2550-test suite', - 'PR `#2001`', - 'GitHub Actions run `26102500291`', - 'owner approval packet', - ]) { + for (const marker of requiredMarkers) { assert.ok(roadmap.includes(marker), `GA roadmap missing current evidence marker ${marker}`); } - assert.ok(!roadmap.includes('preview-pack smoke digest `bc2bf157616e`')); - assert.ok(!roadmap.includes('local 2544-test suite')); + for (const marker of excludedMarkers) { + assert.ok(!roadmap.includes(marker), `GA roadmap contains stale evidence marker ${marker}`); + } });🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@tests/docs/ecc2-release-surface.test.js` around lines 253 - 269, Extract the hardcoded evidence marker strings into named constants at the top of the test (e.g., const MARKER_OWNER_APPROVAL, MARKER_PREVIEW_SMOKE_DIGEST, MARKER_LOCAL_TEST_SUITE, MARKER_PR_NUMBER, MARKER_GHA_RUN, MARKER_OWNER_APPROVAL_ALT and the negative-case constants like MARKER_OLD_PREVIEW_DIGEST, MARKER_OLD_LOCAL_SUITE), then replace the literals in the markers array and the negative assertions with those constants inside the 'GA roadmap mirrors the current May 19 release evidence' test so the test uses descriptive constants (referencing the roadmap variable and the markers array) instead of hardcoded strings.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@scripts/operator-readiness-dashboard.js`:
- Around line 591-592: Extract the duplicated date-stamped artifact path into a
single constant (e.g., OWNER_APPROVAL_PACKET_PATH) and replace the inline
literals used to read the file (currently used when initializing
ownerApprovalPacket via readText and any other occurrences such as where
previewManifest/metadata reference the same path) so both the requirement wiring
and artifact metadata use that constant; update all other duplicate occurrences
mentioned (around the ownerApprovalPacket and the block referenced by the
reviewer, including the section around previewManifest and the region noted as
also applying to 810-814) to reference the new constant instead of hardcoded
strings.
In `@tests/docs/ecc2-release-surface.test.js`:
- Around line 253-269: Extract the hardcoded evidence marker strings into named
constants at the top of the test (e.g., const MARKER_OWNER_APPROVAL,
MARKER_PREVIEW_SMOKE_DIGEST, MARKER_LOCAL_TEST_SUITE, MARKER_PR_NUMBER,
MARKER_GHA_RUN, MARKER_OWNER_APPROVAL_ALT and the negative-case constants like
MARKER_OLD_PREVIEW_DIGEST, MARKER_OLD_LOCAL_SUITE), then replace the literals in
the markers array and the negative assertions with those constants inside the
'GA roadmap mirrors the current May 19 release evidence' test so the test uses
descriptive constants (referencing the roadmap variable and the markers array)
instead of hardcoded strings.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 1ed92059-5ba5-4311-829e-6e24252eabbe
📒 Files selected for processing (11)
docs/ECC-2.0-GA-ROADMAP.mddocs/releases/2.0.0-rc.1/operator-readiness-dashboard-2026-05-19.mddocs/releases/2.0.0-rc.1/owner-approval-packet-2026-05-19.mddocs/releases/2.0.0-rc.1/preview-pack-manifest.mddocs/releases/2.0.0-rc.1/publication-evidence-2026-05-19.mddocs/releases/2.0.0-rc.1/publication-readiness.mdscripts/operator-readiness-dashboard.jsscripts/platform-audit.jstests/docs/ecc2-release-surface.test.jstests/scripts/operator-readiness-dashboard.test.jstests/scripts/platform-audit.test.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
Summary by cubic
Adds an owner approval packet gate to the operator readiness dashboard to block any publish or outbound steps until explicit owner decisions are recorded. Refreshes May 19 evidence/roadmap to PR #2001 and 2550/2550 local suite, and updates checks/tests accordingly.
owner-approval-packet-2026-05-19.mdand its presence in the preview manifest.790430aef4a8, PR Add rc.1 owner approval packet #2001, CI run26102500291, and 2550-test local suite.Written for commit 0590ed1. Summary will update on new commits. Review in cubic
Summary by CodeRabbit
Documentation
Tests