docs: record stale salvage gap pass by affaan-m · Pull Request #1818 · affaan-m/everything-claude-code

affaan-m · 2026-05-12T19:05:46Z

Summary

Records the next stale-PR salvage gap pass after the code-reviewer guardrail salvage in #1817.

Classifications added

already present: fix(hooks): bypass gateguard friction gates inside subagent invocations (#1548) #1567, fix: restore llm.prompt public imports #1570, fix(hooks): use iTerm2 native escape so notification clicks focus the iTerm tab #1584, fix(ci): detect unsafe checkouts even when uses: value is quoted #1589, fix(hooks): treat HTTP 400 MCP probes as reachable #1594, fix(ci): validate plugin catalog counts #1597, docs(continuous-learning): mark v1 as deprecated; route to v2 #1602, docs(rules/web/hooks): add --incremental + timeout to tsc hook example #1613, fix: parse all Claude content blocks #1648
skipped: Feature/install ecc local #1604 Windows drag-and-drop local installer, superseded by the managed installer/profile flow
translator/manual review: docs: add Persian (Farsi) translation of README #1609 and docs(zh-TW): sync outdated/missing sections with English README #1563/docs(tr): sync outdated Quick Start sections with English README #1564/docs(pt-BR): sync outdated Quick Start sections with English README #1565 README localization syncs

Validation

node tests/docs/stale-pr-salvage-ledger.test.js
npx --yes markdownlint-cli docs/stale-pr-salvage-ledger.md
git diff --check

Summary by cubic

Records the May 12 stale-PR salvage gap pass and updates tests to lock the new classifications. Adds “already present” entries for #1567, #1570, #1584, #1589, #1594, #1597, #1602, #1613, #1648; skips #1604 (Windows drag‑and‑drop installer); and keeps localization PRs (#1609, #1563/#1564/#1565, #1687) in translator/manual review with updated handling rules.

^{Written for commit b7fcd73. Summary will update on new commits.}

Summary by CodeRabbit

Documentation
- Updated stale pull request salvage ledger with new classification entries and expanded manual-review backlog handling for localization/translation pull requests.
Tests
- Updated test cases to reflect documentation changes and validate ledger assertions.

coderabbitai · 2026-05-12T19:06:01Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 88ca01cc-ca5f-4c89-9639-3204e7e47b79

📥 Commits

Reviewing files that changed from the base of the PR and between df60af9 and b7fcd73.

📒 Files selected for processing (2)

docs/stale-pr-salvage-ledger.md
tests/docs/stale-pr-salvage-ledger.test.js

📝 Walkthrough

Walkthrough

This PR updates the stale PR salvage ledger documentation by adding 14 new source PR disposition entries to the May 12 gap pass section and expanding the manual-review backlog to include additional localization PRs. Corresponding test assertions are updated to verify the ledger content.

Changes

Stale PR Salvage Ledger: Gap Pass and Backlog Updates

Layer / File(s)	Summary
May 12 gap pass disposition rows and test assertions `docs/stale-pr-salvage-ledger.md`, `tests/docs/stale-pr-salvage-ledger.test.js`	Added 14 new source PR disposition rows (`#1563/`#1564/#1565, `#1567`, `#1570`, `#1584`, `#1589`, `#1594`, `#1597`, `#1602`, `#1603`, `#1604`, `#1609`, `#1613`, `#1631`, `#1648`) in the gap pass table with translator/manual-review and skip statuses. Test updated to assert the revised PR list entries and count.
Manual-review backlog expansion and test phrase assertions `docs/stale-pr-salvage-ledger.md`, `tests/docs/stale-pr-salvage-ledger.test.js`	Expanded the "Remaining Manual-Review Backlog" section from one to four PRs (`#1609`, `#1563`, `#1564`, `#1565`, all localization-related). Test updated to verify localization tail statements, new ledger phrases (GateGuard subagent file-gate bypass, HTTP MCP reachability handling, managed installer/profile flow), and the expanded backlog list.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

affaan-m/everything-claude-code#1817: Both PRs modify docs/stale-pr-salvage-ledger.md and tests to add/update salvage disposition entries for specific source PRs.
affaan-m/everything-claude-code#1813: Both PRs modify the May 12 gap pass section of the ledger and adjust corresponding test assertions for salvage-attribution rows.
affaan-m/everything-claude-code#1812: Both PRs update docs/stale-pr-salvage-ledger.md and test expectations to add May 12 gap pass salvage entries.

Poem

🐰 A ledger kept tidy, no PR left behind,
Translation tails bundled, just so they align,
May's gap pass grows full with fresh sorting done,
Tests verify whispers—the backlog's begun! 🌿✨

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'docs: record stale salvage gap pass' clearly and concisely summarizes the main change: documenting the completion of a stale PR salvage gap pass with classifications for multiple PRs.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch codex/stale-salvage-ledger-gap-pass

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

greptile-apps · 2026-05-12T19:09:58Z

Greptile Summary

Records the next stale-PR salvage gap pass, adding 11 new classified entries to the May 12 table and expanding the manual-review backlog from a single-item note to a structured bullet list of 5 localization PRs.

docs/stale-pr-salvage-ledger.md: adds "already present", "skipped", and "translator/manual review" dispositions for PRs docs(zh-TW): sync outdated/missing sections with English README #1563–fix: parse all Claude content blocks #1648, adds Feature/install ecc local #1604 to the Skipped section, and replaces the old single-sentence backlog prose with an explicit bullet list.
tests/docs/stale-pr-salvage-ledger.test.js: updates the gap-pass and manual-review backlog tests to assert on every newly-added entry, with a minor coverage gap for #1564 and #1565 in the backlog test.

Confidence Score: 4/5

Safe to merge — purely documentation and test changes with no runtime impact.

The test for the manual-review backlog checks for #1563 zh-TW README sync but omits corresponding assertions for #1564 Turkish README sync and #1565 pt-BR README sync, which are also newly added to the ledger in this PR. Accidental omission of those two bullets would go undetected by the test suite.

tests/docs/stale-pr-salvage-ledger.test.js — the backlog test is missing assertions for #1564 and #1565.

Important Files Changed

Filename	Overview
docs/stale-pr-salvage-ledger.md	Adds 11 new gap-pass entries (#1563–#1648) to the May 12 table, expands the Skipped section with #1604, and replaces the single-item manual-review backlog prose with a structured bullet list covering 5 localization PRs.
tests/docs/stale-pr-salvage-ledger.test.js	Updates the gap-pass test to assert on all newly-added PR entries and rewrites the manual-review backlog assertion; missing assertions for #1564 and #1565 leave a small coverage gap.

_{Reviews (1): Last reviewed commit: "docs: record stale salvage gap pass" | Re-trigger Greptile}

greptile-apps · 2026-05-12T19:10:01Z

+  assert.ok(source.includes('The remaining plausibly useful backlog is translation/localization work'));
+  assert.ok(source.includes('#1687 zh-CN localization tail'));
+  assert.ok(source.includes('#1609 Persian README translation'));
+  assert.ok(source.includes('#1563 zh-TW README sync'));
  assert.ok(source.includes('translator/manual review'));
  assert.ok(source.includes('Do not import stale top-level docs'));
 });


Incomplete manual-review backlog assertions

The test checks for #1563 zh-TW README sync but does not assert on #1564 Turkish README sync or #1565 pt-BR README sync, both of which were added to the Remaining Manual-Review Backlog in this same PR. If either bullet is accidentally omitted or misspelled in the ledger, the test will still pass.

docs: record stale salvage gap pass

b7fcd73

greptile-apps Bot reviewed May 12, 2026

View reviewed changes

affaan-m merged commit 4f5f612 into main May 12, 2026
40 checks passed

affaan-m deleted the codex/stale-salvage-ledger-gap-pass branch May 12, 2026 19:18

affaan-m mentioned this pull request May 12, 2026

docs: sync roadmap discussion and salvage evidence #1819

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

docs: record stale salvage gap pass#1818

docs: record stale salvage gap pass#1818
affaan-m merged 1 commit into
mainfrom
codex/stale-salvage-ledger-gap-pass

affaan-m commented May 12, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented May 12, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Poem

Uh oh!

greptile-apps Bot commented May 12, 2026

Uh oh!

greptile-apps Bot May 12, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

affaan-m commented May 12, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Classifications added

Validation

Summary by cubic

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented May 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Poem

Uh oh!

greptile-apps Bot commented May 12, 2026

Greptile Summary

Confidence Score: 4/5

Important Files Changed

Uh oh!

greptile-apps Bot May 12, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

affaan-m commented May 12, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented May 12, 2026 •

edited

Loading