Skip to content

Commit 13795b8

Browse files
Fix crash in selectionBox when gltf-model loads after entity is detached (#856)
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent 70d0557 commit 13795b8

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

src/lib/viewport.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -167,9 +167,10 @@ export function Viewport(inspector) {
167167
} else if (object.el.hasAttribute('gltf-model')) {
168168
const listener = (event) => {
169169
if (event.target !== object.el) return; // we got an event for a child, ignore
170+
object.el.removeEventListener('model-loaded', listener);
171+
if (object.parent === null) return; // entity was detached before model loaded
170172
selectionBox.setFromObject(object);
171173
selectionBox.visible = true;
172-
object.el.removeEventListener('model-loaded', listener);
173174
};
174175
object.el.addEventListener('model-loaded', listener);
175176
}

0 commit comments

Comments
 (0)