Skip to content

Fix crash in selectionBox when gltf-model loads after entity is detached#856

Merged
dmarcos merged 1 commit into
aframevr:masterfrom
vincentfretin:model-loaded-setFromObject-guard
Apr 28, 2026
Merged

Fix crash in selectionBox when gltf-model loads after entity is detached#856
dmarcos merged 1 commit into
aframevr:masterfrom
vincentfretin:model-loaded-setFromObject-guard

Conversation

@vincentfretin

Copy link
Copy Markdown
Contributor

Very rare case but could happen when you undo/redo a reparent action very quickly in aframe-editor. Here in the inspector that's probably even harder to reproduce, maybe copy an entity having gltf-model, paste and delete enter right away but with the confirmation modal it leave enough time to not produce the error.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@dmarcos

dmarcos commented Apr 28, 2026

Copy link
Copy Markdown
Member

thank you!

@dmarcos
dmarcos merged commit 13795b8 into aframevr:master Apr 28, 2026
1 check passed
@vincentfretin
vincentfretin deleted the model-loaded-setFromObject-guard branch April 28, 2026 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants