fix #101 chose default camera, get more specific if position is wrong#184
Open
SigiNeumann wants to merge 1 commit intoafriscic:masterfrom
Open
fix #101 chose default camera, get more specific if position is wrong#184SigiNeumann wants to merge 1 commit intoafriscic:masterfrom
SigiNeumann wants to merge 1 commit intoafriscic:masterfrom
Conversation
Author
|
For reference I wanted to check how others are doing and it seems that ZXing did a similar change |
Owner
|
There was a request a while back to support dual and triple cameras as they enable smoother zoom experience. Before that the code selected only wide camera. If you experience problem with scanning on iPhones try to set small zoom factor. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#101
It seems on some iPhone (12/13), the picking order of captureDevices would provide suboptimal captureDevices e.g. DualWideCamera on iPhone12, where InWideAngleCamera would be better.
Instead of chosing a specific deviceType, we use the system default and only pick if position (front/back) is wrong. This becomes neccessary bc. of the overloads of getDefaultDevice