Add OnCameraPreviewReady event#195
Open
VagnerVit wants to merge 1 commit intoafriscic:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new
OnCameraPreviewReadyevent andOnCameraPreviewReadyCommandbindable property toCameraView, fired once when the camera preview becomes ready.Closes #194
Motivation
There is currently no public API to know when the camera preview is actually rendering. Users resort to fragile workarounds like fixed
Task.Delayor monitoringCurrentZoomFactorviaPropertyChangedto hide loading overlays at the right moment.Changes
OnCameraPreviewReadyEventArg— simple EventArgs subclass (follows existing pattern)CameraView— new event, bindable command, and internal trigger method with a guard flag ensuring it fires only once per camera session (reset onStart)CameraStateObserver.OnChanged()whenCameraState.Type.Openis reachedStart()dispatch block after session starts runningUsage