feat: Use DependencyPropertyGenerator#26
Conversation
|
Not sure about the default DefaultBindingMode.TwoWay. This only makes sense for those properties that can be changed from library side |
|
I checked the platform methods and didn't see anything changing these properties. So I removed all DefaultBindingMode.TwoWay |
propertyChanged: (bindable, value, newValue) => ((CameraView)bindable).OnDetectionFinishedCommand = (ICommand)newValueFor the future - you don't need to write code like this, this duplication and assignment already happens in the property setter. |
|
@HavenDV Looking at this, I think I can see that you are trying to use this new dep to make the code more readable, but I'm not sure. Would you mind adding a description to this pull request, explaining your reason for making the changes? This may help the owner decide on it. EDIT: You probably should also disclaim that you the owner of the added dep. Not that this is bad, but it should be considered, when deciding on adding new (maybe permanent) dependencies to the project. |
| <ItemGroup> | ||
| <PackageReference Include="Microsoft.Maui.Controls" Version="$(MauiVersion)" /> | ||
| <PackageReference Include="Microsoft.Maui.Controls.Compatibility" Version="$(MauiVersion)" /> | ||
| <PackageReference Include="DependencyPropertyGenerator" Version="1.5.0-beta.1"> |
There was a problem hiding this comment.
I don't think this project should consume beta (pre-release) versions of nuget packages. Maybe wait, until it's released?
|
#25 |
|
Sorry, this is on hold for now as I currently don't have enough time to test it properly. |
3 participants
No description provided.