Skip to content
This repository was archived by the owner on Aug 19, 2024. It is now read-only.

Commit 983b597

Browse files
committed
AG-1053 Tidy react examples, make more idiomatic
1 parent b030235 commit 983b597

149 files changed

Lines changed: 338 additions & 8855 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
const path = require('path');
22

3-
const SRC_DIR = path.resolve(__dirname, 'src');
3+
const SRC_DIR = path.resolve(__dirname, '../src-examples');
44

55
module.exports = {
66
entry: SRC_DIR + "/index.js",
77
output: {
8-
path: __dirname,
8+
path: path.resolve(__dirname, '../'),
99
filename: "dist/react-examples.js"
1010
},
1111
module: {
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
const path = require('path');
22

3-
const SRC_DIR = path.resolve(__dirname, 'src-large');
3+
const SRC_DIR = path.resolve(__dirname, '../src-large-data');
44

55
module.exports = {
66
entry: SRC_DIR + "/index.js",
77
output: {
8-
path: __dirname,
8+
path: path.resolve(__dirname, '../'),
99
filename: "dist/react-large.js"
1010
},
1111
module: {
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
const path = require('path');
22

3-
const SRC_DIR = path.resolve(__dirname, 'src-trader-dashboard');
3+
const SRC_DIR = path.resolve(__dirname, '../src-trader-dashboard');
44

55
module.exports = {
66
entry: SRC_DIR + "/index.js",
77
output: {
8-
path: __dirname,
8+
path: path.resolve(__dirname, '../'),
99
filename: "dist/react-trader.js"
1010
},
1111
module: {

olympicWinners.json

Lines changed: 0 additions & 8618 deletions
This file was deleted.

package.json

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,17 +4,17 @@
44
"description": "Example Reach applicaiton using ag-Grid.",
55
"main": "dist/ag-grid-react-example.js",
66
"scripts": {
7-
"trader": "webpack-dev-server --content-base src-trader-dashboard/ --config webpack.config.trader.js --progress --colors --hot --inline",
8-
"examples": "webpack-dev-server --content-base src/ --config webpack.config.examples.js --progress --colors --hot --inline",
9-
"large": "webpack-dev-server --content-base src-large/ --config webpack.config.large.js --progress --colors --hot --inline",
7+
"trader": "webpack-dev-server --content-base src-trader-dashboard/ --config config/webpack.config.trader.js --progress --colors --hot --inline",
8+
"examples": "webpack-dev-server --content-base src-examples/ --config config/webpack.config.examples.js --progress --colors --hot --inline",
9+
"large": "webpack-dev-server --content-base src-large-data/ --config config/webpack.config.large.js --progress --colors --hot --inline",
1010
"clean": "rimraf dist",
1111
"mkdirs": "mkdirp dist/trader/dist dist/examples/dist",
1212
"copy-examples": "ncp images dist/examples/images && ncp src/index.html dist/examples/index.html && ncp dist/react-examples.js dist/examples/dist/react-examples.js && ncp src dist/examples/src",
1313
"copy-trader": "ncp src-trader-dashboard/index.html dist/trader/index.html && ncp dist/react-trader.js dist/trader/dist/react-trader.js",
1414
"copy": "npm run copy-examples && npm run copy-trader",
15-
"build-large": "webpack --config webpack.config.large.js --progress --profile --bail",
16-
"build-examples": "webpack --config webpack.config.examples.js --progress --profile --bail",
17-
"build-dashboard": "webpack --config webpack.config.trader.js --progress --profile --bail",
15+
"build-large": "webpack --config config/webpack.config.large.js --progress --profile --bail",
16+
"build-examples": "webpack --config config/webpack.config.examples.js --progress --profile --bail",
17+
"build-dashboard": "webpack --config config/webpack.config.trader.js --progress --profile --bail",
1818
"build-all": "npm run build-examples && npm run build-dashboard",
1919
"build": "npm run clean && npm run mkdirs && npm run build-all && npm run copy",
2020
"copy-to-docs": "ncp dist/examples ../ag-grid-docs/src/framework-examples/react-examples/examples && ncp dist/trader ../ag-grid-docs/src/framework-examples/react-examples/trader",
File renamed without changes.

src/dynamicComponentExample/ChildMessageRenderer.jsx renamed to src-examples/dynamicComponentExample/ChildMessageRenderer.jsx

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,13 +3,14 @@ import React, {Component} from "react";
33
export default class ChildMessageRenderer extends Component {
44
constructor(props) {
55
super(props);
6-
7-
this.invokeParentMethod = this.invokeParentMethod.bind(this);
86
}
97

10-
invokeParentMethod() {
11-
this.props.context.componentParent.methodFromParent(`Row: ${this.props.node.rowIndex}, Col: ${this.props.colDef.headerName}`)
12-
}
8+
invokeParentMethod = () => {
9+
let rowIndex = this.props.node.rowIndex;
10+
let headerName = this.props.colDef.headerName;
11+
12+
this.props.context.componentParent.methodFromParent(`Row: ${rowIndex}, Col: ${headerName}`)
13+
};
1314

1415
render() {
1516
return (
File renamed without changes.

src/dynamicComponentExample/CurrencyRenderer.jsx renamed to src-examples/dynamicComponentExample/CurrencyRenderer.jsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ export default class CurrencyRenderer extends Component {
99
}
1010
}
1111

12-
formatValueToCurrency(currency, value) {
12+
static formatValueToCurrency(currency, value) {
1313
return `${currency}${value}`
1414
}
1515

@@ -25,7 +25,7 @@ export default class CurrencyRenderer extends Component {
2525

2626
render() {
2727
return (
28-
<span>{this.formatValueToCurrency('EUR', this.state.value)}</span>
28+
<span>{CurrencyRenderer.formatValueToCurrency('EUR', this.state.value)}</span>
2929
);
3030
}
3131
};

0 commit comments

Comments
 (0)