Skip to content
This repository was archived by the owner on Aug 19, 2024. It is now read-only.

Commit b030235

Browse files
committed
AG-530 Implement React declarative offering
1 parent 351d93b commit b030235

6 files changed

Lines changed: 23 additions & 13 deletions

File tree

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
"scripts": {
77
"trader": "webpack-dev-server --content-base src-trader-dashboard/ --config webpack.config.trader.js --progress --colors --hot --inline",
88
"examples": "webpack-dev-server --content-base src/ --config webpack.config.examples.js --progress --colors --hot --inline",
9-
"large": "webpack-dev-server --config webpack.config.large.js --progress --colors --hot --inline",
9+
"large": "webpack-dev-server --content-base src-large/ --config webpack.config.large.js --progress --colors --hot --inline",
1010
"clean": "rimraf dist",
1111
"mkdirs": "mkdirp dist/trader/dist dist/examples/dist",
1212
"copy-examples": "ncp images dist/examples/images && ncp src/index.html dist/examples/index.html && ncp dist/react-examples.js dist/examples/dist/react-examples.js && ncp src dist/examples/src",

index.html renamed to src-large/index.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
<head>
77
<meta charset="utf-8">
8-
<script type="text/javascript" src="dist/bundle.js" charset="utf-8"></script>
8+
<script type="text/javascript" src="dist/react-large.js" charset="utf-8"></script>
99
<!-- Example uses font awesome icons -->
1010
<link href="//maxcdn.bootstrapcdn.com/font-awesome/4.2.0/css/font-awesome.min.css" rel="stylesheet">
1111
</head>

src-large/index.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,9 @@
33
import ReactDOM from 'react-dom';
44
import React from 'react';
55
import LargeGrid from './largeGrid.jsx';
6-
// is there a better way of doing this?
7-
import 'ag-grid-root/dist/styles/ag-grid.css';
8-
import 'ag-grid-root/dist/styles/theme-fresh.css';
6+
7+
import 'ag-grid/dist/styles/ag-grid.css';
8+
import 'ag-grid/dist/styles/theme-fresh.css';
99

1010
// waiting for dom to load before booting react. we could alternatively
1111
// put the index.js reference at the end fo the index.html, but i prefer this way.

src-trader-dashboard/index.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@ import {render} from "react-dom";
55

66
import {Provider} from "react-redux";
77

8-
import "ag-grid-root/dist/styles/ag-grid.css";
9-
import "ag-grid-root/dist/styles/theme-fresh.css";
8+
import "ag-grid/dist/styles/ag-grid.css";
9+
import "ag-grid/dist/styles/theme-fresh.css";
1010

1111
import StoreService from './services/StoreService';
1212
import TraderDashboard from "./components/TraderDashboard.jsx";

webpack.config.large.js

Lines changed: 13 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,12 @@
1+
const path = require('path');
2+
3+
const SRC_DIR = path.resolve(__dirname, 'src-large');
4+
15
module.exports = {
2-
entry: "./src-large/index.js",
6+
entry: SRC_DIR + "/index.js",
37
output: {
48
path: __dirname,
5-
filename: "dist/bundle.js"
9+
filename: "dist/react-large.js"
610
},
711
module: {
812
loaders: [
@@ -12,16 +16,20 @@ module.exports = {
1216
},
1317
{
1418
test: /\.js$|\.jsx$/,
19+
include: SRC_DIR,
1520
loader: 'babel-loader',
1621
query: {
17-
presets: ['react', 'es2015']
22+
presets: ['react', 'es2015', 'stage-0']
1823
}
1924
}
2025
]
2126
},
2227
resolve: {
2328
alias: {
24-
"ag-grid-root" : __dirname + "/node_modules/ag-grid"
25-
}
29+
"ag-grid": path.resolve('./node_modules/ag-grid'),
30+
"ag-grid-enterprise": path.resolve('./node_modules/ag-grid-enterprise'),
31+
react: path.resolve('./node_modules/react')
32+
},
33+
extensions: ['', '.js', '.jsx']
2634
}
2735
};

webpack.config.trader.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,9 @@ module.exports = {
2626
},
2727
resolve: {
2828
alias: {
29-
"ag-grid-root" : __dirname + "/node_modules/ag-grid"
29+
"ag-grid": path.resolve('./node_modules/ag-grid'),
30+
"ag-grid-enterprise": path.resolve('./node_modules/ag-grid-enterprise'),
31+
react: path.resolve('./node_modules/react')
3032
},
3133
extensions: ['', '.js', '.jsx']
3234
}

0 commit comments

Comments
 (0)