feat(profile): optional display name on register + nudge banner#49
Merged
Conversation
Frontend slice of #46. Login-by-username (#46 step 3) is deferred — it depends on auth-api work that hasn't shipped yet. - Add an optional Display-name input on /register, between confirm- password and the TOS checkbox. Empty submission is fine. If provided, PATCH /auth/me after the auto-login completes. Failures are swallowed so a transient PATCH error doesn't undo a successful registration — the /profile nudge below will re-prompt. - Add a nudge banner at the top of /profile when display_name is null. Dismissible per session via sessionStorage, auto-disappears once a name is set. Doesn't interrupt the cross-origin redirect flow because new users registering through a consumer-app link (e.g. hera-streamer-…) typically bounce out before reaching /profile. OAuth (Google/Steam) users already get display_name auto-populated from the provider profile by the auth-api, so the banner only fires for password registrants who skipped the optional field.
✅ Deploy Preview for criticalbit-auth-web ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Frontend slice of #46. Login-by-username (#46 step 3) is deferred — it depends on auth-api work that hasn't shipped yet.
What's in this PR
What's deferred
OAuth users
Google and Steam OAuth users already get `display_name` auto-populated from the provider profile by the auth-api, so the banner only fires for password registrants who skipped the optional field. The issue mentioned suggesting it to Google OAuth users specifically — that's covered transitively (if their Google profile somehow lacked a name, they'd see the nudge on /profile).
Test plan