fix(aws-strands): preserve plugins on per-thread agents#1954
fix(aws-strands): preserve plugins on per-thread agents#19542830500285 wants to merge 2 commits into
Conversation
|
@2830500285 is attempting to deploy a commit to the CopilotKit Team on Vercel. A member of the Team first needs to authorize it. |
|
Thanks for tackling this. The explicit The current tests prove that an explicit kwarg is forwarded through a mocked core, but they do not cover the linked issue's actual shape: a template Strands The main risk is around tool registration. This PR forwards the plugin list while still passing I think this needs a regression test with a real plugin that registers both a tool and a hook, ideally |
|
Closing in favor of #2141, which addresses the same aws-strands per-thread plugin preservation (same files) and has already been reviewed/approved. Let's land it there. Thanks @2830500285 — appreciate the fix. |
Fixes #1933
Summary
pluginsoption to the PythonStrandsAgentwrapperplugins_plugin_registry.add_and_init(...)when available, and warn instead of silently dropping plugins otherwiseValidation
uv run pytest tests/test_template_plugins_preservation.py tests/test_template_agent_propagation.py tests/test_template_hooks_preservation.py -quv run pytest -quv run python -m compileall -q src tests/test_template_plugins_preservation.py tests/test_template_agent_propagation.pygit diff --checkuv run ruff format --check tests/test_template_plugins_preservation.py && uv run ruff check tests/test_template_plugins_preservation.py