Move network to use the new actor service based model#3340
Draft
teclator wants to merge 6 commits into
Draft
Conversation
teclator
force-pushed
the
network_service_feature
branch
from
b340529 to
10cf2e6
Compare
Merged
teclator
added a commit
that referenced
this pull request
May 14, 2026
## Problem Some problems have been detected in the API when working on some UI PBIs. 1. The current connections list exposes the status of the connection, but the status is a field for defining if the connection should be up, down or to keep the current state( a user setting ). Instead of the connection status the list should expose the connection state. 2. The IPv6 method has more options that are not defined in the schema. 3. The network changes are applied even if the user config does not change. 4. If the user config has change it updates all the connections defined in the profile even when there are no real changes (a merge with the backend connection is the same). 5. When a controller ports are modified, them keep being defined as ports or even are created as duplicate. 6. When the network is written, it returns once the connections are updated (written) but the connections could get time to get activated or deactivated. ## Solution 1. Bring back the connection state exposing it in the system configuration. 2. Define the missing methods for IPv6. 3. Store the user config and check if it has change or not. 4. Do a merge of the given user config with the backend to compare them properly. 5. Handle better the ports definition removing the orphaned ones. 6. Do not finish writing the configuration until all the generated active connections are activated or deactivated at least once. This PR was also handled by #3340, but in order to get it merge ASAP I have moved some code from there. ## Tests - Tested manually
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow up of the HTTP API v2 transition in this case moving from the enum Actions based approach to the trait one followed by the rest of clients.