[ refactor ] make Relation.Binary.Morphism.Definitions obsolete#2922
Open
jamesmckinna wants to merge 7 commits intoagda:masterfrom
Open
[ refactor ] make Relation.Binary.Morphism.Definitions obsolete#2922jamesmckinna wants to merge 7 commits intoagda:masterfrom
Relation.Binary.Morphism.Definitions obsolete#2922jamesmckinna wants to merge 7 commits intoagda:masterfrom
Conversation
This was referenced Jan 24, 2026
jamesmckinna
commented
Jan 26, 2026
jamesmckinna
requested review from
JacquesCarette,
MatthewDaggitt and
gallais
and removed request for
JacquesCarette
jamesmckinna
commented
Feb 18, 2026
Collaborator
JacquesCarette
left a comment
JacquesCarette
left a comment
There was a problem hiding this comment.
Putting as comment, since I don't want to block merge on just this.
Collaborator
Author
|
Is this an Agda bug now? Or simply that I don't understand the semantics of |
JacquesCarette
approved these changes
Mar 15, 2026
Member
|
See previous discussion: #2318 |
MatthewDaggitt
requested changes
Apr 8, 2026
Collaborator
Author
Collaborator
Author
|
@MatthewDaggitt over to you to re-review before merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This tackles the first part of #2875 , retaining the module solely for compatibility per #1206 / #1213 as requested by @pnlph , so no actual
deprecationat this stage.Knock-on consequences include:
Function.Definitionsvs. alternativesHomomorphic₂throughout byFunction.Definitions.Congruent(but the name is still exported aspublicby the obsolete stub; and hence also exported byRelation.Binary.Morphism, but this could be removed/deprecated?)Apologies to @Taneb for having changed my mind regarding your original #2318 but this PR should now close that issue as 'fixed'!
TL;DR: the 'cause' of the problem is yet again [ DRY ] with some basic concepts duplicated across the
Function/Relation/Algebrahierarchies as various specialisations (or not even that) of 'common' (very) general abstractions (eg 'monotonicity'/'congruence'/'respects') which different authors have, at different times, identified asCoreto one or other hierarchy... cf. #2917