Add tool to scan for references of deleted or renamed READMEs#3041
Open
silas-hw wants to merge 10 commits into
Open
Add tool to scan for references of deleted or renamed READMEs#3041silas-hw wants to merge 10 commits into
silas-hw wants to merge 10 commits into
Conversation
silas-hw
changed the title
JacquesCarette
approved these changes
Jun 30, 2026
JacquesCarette
left a comment
JacquesCarette
left a comment
Collaborator
There was a problem hiding this comment.
I have not done shell scripting in far, far too long, so my 'approve' should be considered fairly weak. I see no immediate problem here, BUT... (Of course, I do think that the idea is good and helpful.)
gallais
reviewed
Jul 1, 2026
gallais
left a comment
gallais
left a comment
Member
There was a problem hiding this comment.
I'm not a huge fan of the fact that master is hard coded in the script.
E.g. when we (rarely) are merging into experimental, master's status is irrelevant.
Co-authored-by: G. Allais <guillaume.allais@ens-lyon.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.github/tooling/defunct-readme.sh, which compares the current branch againstmasterto see if any READMEs have been deleted, and if so scans for references to that README in other files. If any are found, the script exits with an error