Fix live stop errors and status display (#58)

shaypal5 · web-flow · commit 738597db1a6a · 2026-05-26T12:02:06.000+03:00
diff --git a/functions/api/[[path]].ts b/functions/api/[[path]].ts
@@ -1765,14 +1765,19 @@ async function listLiveConversations(env: Env, status?: string | null) {
 }
 
 async function updateLiveConversation(request: Request, env: Env, sessionId: string) {
-  const db = requireDb(env);
-  if (!db.ok) return json({ error: "Live conversations require durable storage." }, 503);
   const input = await body(request);
   if (!["active", "waiting_on_peer", "settled_by_agent", "operator_stop_needed", "stopped"].includes(String(input.status))) {
     return json({ error: "Invalid live conversation status." }, 400);
   }
+  const db = requireDb(env);
+  if (!db.ok) return json({ error: "Live conversations require durable storage." }, 503);
   await db.db
-    .prepare("UPDATE live_conversation_sessions SET status = ?, stopped_at = CASE WHEN ? = 'stopped' THEN ? ELSE NULL END WHERE id = ?")
+    .prepare(
+      `UPDATE live_conversation_sessions
+       SET status = ?,
+           stopped_at = CASE WHEN ? = 'stopped' THEN CAST(? AS timestamptz) ELSE NULL END
+       WHERE id = ?`,
+    )
     .bind(input.status, input.status, now(), sessionId)
     .run();
   const row = await db.db.prepare("SELECT * FROM live_conversation_sessions WHERE id = ?").bind(sessionId).first<Row>();
diff --git a/src/App.tsx b/src/App.tsx
@@ -212,6 +212,16 @@ export AGENT_COMMS_TOKEN="${token}"
 `;
 }
 
+function readableRequestError(value: unknown) {
+  const message = String(value ?? "").trim();
+  if (!message) return "Operator request failed.";
+  if (message.includes("<!DOCTYPE html") || message.includes("<html")) {
+    if (message.includes("Worker threw exception")) return "Cloudflare Worker threw an exception. Check the API logs.";
+    return "Server returned an HTML error page.";
+  }
+  return message.length > 240 ? `${message.slice(0, 237)}...` : message;
+}
+
 function agentTokenFileCommand(agent: AgentIdentity, token: string) {
   return `umask 077; cat > agent-comms-token.env <<'EOF'\n${agentTokenEnvFile(agent, token)}EOF\n`;
 }
@@ -1345,7 +1355,7 @@ export function App() {
       const payload = contentType.includes("application/json")
         ? await response.json()
         : { error: await response.text() };
-      if (!response.ok) throw new Error(payload.error ?? "Operator request failed.");
+      if (!response.ok) throw new Error(readableRequestError(payload.error ?? "Operator request failed."));
       return payload;
     },
     [operatorToken],
diff --git a/tests/api-auth.test.ts b/tests/api-auth.test.ts
@@ -185,4 +185,26 @@ describe("API auth", () => {
     expect(response.status).toBe(200);
     expect(payload.schemas?.agent?.createDirectConversation).toEqual({ agentId: "string", peerAgentId: "string" });
   });
+
+  it("rejects invalid live conversation status before storage access", async () => {
+    const request = new Request("https://example.test/api/operator/live-conversations/live_123/status", {
+      method: "POST",
+      headers: {
+        authorization: "Bearer operator-token",
+        "content-type": "application/json",
+      },
+      body: JSON.stringify({ status: "paused" }),
+    });
+
+    const response = await onRequest({
+      request,
+      env: { OPERATOR_API_TOKEN: "operator-token" } as never,
+    });
+    expect(response).toBeDefined();
+    if (!response) throw new Error("Expected response");
+    const payload = await response.json() as { error?: string };
+
+    expect(response.status).toBe(400);
+    expect(payload.error).toBe("Invalid live conversation status.");
+  });
 });
