Commit 6f00559
authored
chore: rewrite PR template to match real scripts + Changesets flow (#16)
## Summary
The existing `.github/pull_request_template.md` is a 5-line stub.
Replace it with a structured template (Summary / Changes / Verification
/ Notes for reviewers) that points contributors at the Changesets
workflow and the README-update expectation for public API changes.
This is the last bit of repo-docs scaffolding called out in the PR C
deliverables for
[agent-labs-dev/nebula-desktop#153](agent-labs-dev/nebula-desktop#153).
## Changes
- Rewrite `.github/pull_request_template.md`:
- Add Summary / Changes / Notes-for-reviewers sections (only Summary +
Verification existed before)
- Verification checklist references `pnpm check` and `pnpm
test:electron` (matches `package.json` and `CONTRIBUTING.md`)
- Add a "changeset staged or empty" item so contributors don't break the
release workflow
- Add a "public API change reflected in README" item
- Add a "no secrets / .env" item
- Add an empty changeset (`.changeset/pr-template-rewrite.md`) since
this is repo meta
## Verification
- [x] No source/test changes; CI `check` and `electron-smoke` jobs
unaffected
- [x] Empty changeset staged per `CONTRIBUTING.md` (Releases section)
- [x] Script names cross-checked against `package.json` (`pnpm check`,
`pnpm test:electron`)
- [x] No secrets, tokens, or `.env*` files included
## Notes for reviewers
The verification checklist intentionally mirrors what `CONTRIBUTING.md`
already says, so contributors don't have to keep two lists in sync
mentally. If you'd rather have the template stay terse and lean on
`CONTRIBUTING.md` for the checklist, happy to slim it back down.
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
* **Chores**
* Updated pull request template with enhanced author guidance and a more
detailed verification checklist requiring explicit local checks
(lint/typecheck/tests/build) and conditional smoke tests
* Added a "Notes for reviewers" section for contextual and
security-sensitive callouts
* Added a changeset configuration entry to document release/process
expectations
<!-- end of auto-generated comment: release notes by coderabbit.ai -->1 parent e2095ff commit 6f00559
2 files changed
Lines changed: 41 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
1 | 14 | | |
2 | 15 | | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
3 | 28 | | |
4 | 29 | | |
5 | | - | |
6 | | - | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
0 commit comments